Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-21 Thread James Bottomley
On Mon, 2008-01-21 at 09:56 +, Christoph Hellwig wrote: > On Fri, Jan 18, 2008 at 04:20:40PM +0900, Tejun Heo wrote: > > aha152x.c and fdomain are built twice - once for the isa driver and > > once for the PCMCIA one. Through #ifdefs, the compiled codes are > > slightly different; thus,

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-21 Thread Christoph Hellwig
On Fri, Jan 18, 2008 at 04:20:40PM +0900, Tejun Heo wrote: > aha152x.c and fdomain are built twice - once for the isa driver and > once for the PCMCIA one. Through #ifdefs, the compiled codes are > slightly different; thus, global symbols need to be given different > names depending on which

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-21 Thread Christoph Hellwig
On Fri, Jan 18, 2008 at 04:20:40PM +0900, Tejun Heo wrote: aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given different names depending on which flavor

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-21 Thread James Bottomley
On Mon, 2008-01-21 at 09:56 +, Christoph Hellwig wrote: On Fri, Jan 18, 2008 at 04:20:40PM +0900, Tejun Heo wrote: aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread Tejun Heo
James Bottomley wrote: >> I'm just a bit reluctant to touch these drivers, since they're all >> incredibly ancient. We don't have good luck with simple transformation >> patches on the older drivers ... and it seems to take months before >> anyone notices there's a problem. > > This is the patch

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread James Bottomley
On Fri, 2008-01-18 at 17:32 -0600, James Bottomley wrote: > On Sat, 2008-01-19 at 08:27 +0900, Tejun Heo wrote: > > James Bottomley wrote: > > > On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: > > >> aha152x.c and fdomain are built twice - once for the isa driver and > > >> once for the

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread Tejun Heo
James Bottomley wrote: >> I personally think it's a bit odd to disallow building into kernel >> because of the peculiarity of the implementation (including c files and >> compiling them slightly differently) and also no one reporting doesn't >> necessarily mean no one has attempted it and failed.

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread James Bottomley
On Sat, 2008-01-19 at 08:27 +0900, Tejun Heo wrote: > James Bottomley wrote: > > On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: > >> aha152x.c and fdomain are built twice - once for the isa driver and > >> once for the PCMCIA one. Through #ifdefs, the compiled codes are > >> slightly

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread Tejun Heo
Tejun Heo wrote: > James Bottomley wrote: >> On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: >>> aha152x.c and fdomain are built twice - once for the isa driver and >>> once for the PCMCIA one. Through #ifdefs, the compiled codes are >>> slightly different; thus, global symbols need to be

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread Tejun Heo
James Bottomley wrote: > On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: >> aha152x.c and fdomain are built twice - once for the isa driver and >> once for the PCMCIA one. Through #ifdefs, the compiled codes are >> slightly different; thus, global symbols need to be given different >> names

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread James Bottomley
On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: > aha152x.c and fdomain are built twice - once for the isa driver and > once for the PCMCIA one. Through #ifdefs, the compiled codes are > slightly different; thus, global symbols need to be given different > names depending on which flavor is

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread James Bottomley
On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given different names depending on which flavor is

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread Tejun Heo
James Bottomley wrote: I personally think it's a bit odd to disallow building into kernel because of the peculiarity of the implementation (including c files and compiling them slightly differently) and also no one reporting doesn't necessarily mean no one has attempted it and failed. Heh

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread Tejun Heo
James Bottomley wrote: I'm just a bit reluctant to touch these drivers, since they're all incredibly ancient. We don't have good luck with simple transformation patches on the older drivers ... and it seems to take months before anyone notices there's a problem. This is the patch that will

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread James Bottomley
On Fri, 2008-01-18 at 17:32 -0600, James Bottomley wrote: On Sat, 2008-01-19 at 08:27 +0900, Tejun Heo wrote: James Bottomley wrote: On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one.

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread James Bottomley
On Sat, 2008-01-19 at 08:27 +0900, Tejun Heo wrote: James Bottomley wrote: On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus,

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread Tejun Heo
James Bottomley wrote: On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given different names depending

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-18 Thread Tejun Heo
Tejun Heo wrote: James Bottomley wrote: On Fri, 2008-01-18 at 16:20 +0900, Tejun Heo wrote: aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given different

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-17 Thread Kamalesh Babulal
On Fri, Jan 18, 2008 at 04:20:40PM +0900, Tejun Heo wrote: > aha152x.c and fdomain are built twice - once for the isa driver and > once for the PCMCIA one. Through #ifdefs, the compiled codes are > slightly different; thus, global symbols need to be given different > names depending on which

[PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-17 Thread Tejun Heo
aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given different names depending on which flavor is being built. This patch adds GLOBAL() macro to aha152x.h and

[PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-17 Thread Tejun Heo
aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given different names depending on which flavor is being built. This patch adds GLOBAL() macro to aha152x.h and

Re: [PATCH] SCSI: fix isa/pcmcia compile problem

2008-01-17 Thread Kamalesh Babulal
On Fri, Jan 18, 2008 at 04:20:40PM +0900, Tejun Heo wrote: aha152x.c and fdomain are built twice - once for the isa driver and once for the PCMCIA one. Through #ifdefs, the compiled codes are slightly different; thus, global symbols need to be given different names depending on which flavor