Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

> On Mar 19, 2021, at 6:08 PM, J. Bruce Fields wrote: > > On Fri, Mar 19, 2021 at 02:58:14PM +, Chuck Lever III wrote: >> Hi Chris- >> >>> On Mar 19, 2021, at 10:54 AM, Chris Down wrote: >>> >>> The reclen is taken directly from the first four bytes of the message >>> with the highest

Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

On Fri, Mar 19, 2021 at 02:58:14PM +, Chuck Lever III wrote: > Hi Chris- > > > On Mar 19, 2021, at 10:54 AM, Chris Down wrote: > > > > The reclen is taken directly from the first four bytes of the message > > with the highest bit stripped, which makes it ripe for protocol mixups. > > For

Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

Hi Chris, Thank you for the patch! Perhaps something to improve: [auto build test WARNING on nfs/linux-next] [also build test WARNING on net/master ipvs/master net-next/master nfsd/nfsd-next v5.12-rc3] [cannot apply to next-20210319] [If your patch is applied to the wrong git tree, kindly drop

Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

Hey Chuck, Thanks for the (very) fast reply! :-) Chuck Lever III writes: This can be confusing for downstream users, who don't know what messages like "fragment too large: 1195725856" actually mean, or that they indicate some misconfigured infrastructure elsewhere. One wonders whether that

Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

Hey folks, Let me know if you'd like more evidence that this is a persisting problem. Also more than happy to change the generation of the whole debug string to go into svc_sock_reclen_ascii or use LOG_CONT if you'd prefer to avoid the multiple ternaries (but the latter probably needs some

Re: [PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

Hi Chris- > On Mar 19, 2021, at 10:54 AM, Chris Down wrote: > > The reclen is taken directly from the first four bytes of the message > with the highest bit stripped, which makes it ripe for protocol mixups. > For example, if someone tries to send a HTTP GET request to us, we'll > interpret it

[PATCH] SUNRPC: Output oversized frag reclen as ASCII if printable

The reclen is taken directly from the first four bytes of the message with the highest bit stripped, which makes it ripe for protocol mixups. For example, if someone tries to send a HTTP GET request to us, we'll interpret it as a 1195725856-sized fragment (ie. (u32)'GET '), and print a ratelimited