Re: [PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-21 Thread Chuck Lever
> On Oct 20, 2020, at 3:16 AM, Martijn de Gouw > wrote: > > Hi, > > On 20-10-2020 00:04, J. Bruce Fields wrote: >> On Mon, Oct 19, 2020 at 03:46:39PM +, Martijn de Gouw wrote: >>> Hi >>> >>> On 19-10-2020 17:23, J. Bruce Fields wrote: On Mon, Oct 19, 2020 at 01:42:27PM +0200,

Re: [PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-20 Thread Martijn de Gouw
Hi, On 20-10-2020 00:04, J. Bruce Fields wrote: > On Mon, Oct 19, 2020 at 03:46:39PM +, Martijn de Gouw wrote: >> Hi >> >> On 19-10-2020 17:23, J. Bruce Fields wrote: >>> On Mon, Oct 19, 2020 at 01:42:27PM +0200, Martijn de Gouw wrote: When the passed token is longer than 4032 bytes, the

Re: [PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-19 Thread J. Bruce Fields
On Mon, Oct 19, 2020 at 03:46:39PM +, Martijn de Gouw wrote: > Hi > > On 19-10-2020 17:23, J. Bruce Fields wrote: > > On Mon, Oct 19, 2020 at 01:42:27PM +0200, Martijn de Gouw wrote: > >> When the passed token is longer than 4032 bytes, the remaining part > >> of the token must be copied from

Re: [PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-19 Thread Martijn de Gouw
Hi On 19-10-2020 17:23, J. Bruce Fields wrote: > On Mon, Oct 19, 2020 at 01:42:27PM +0200, Martijn de Gouw wrote: >> When the passed token is longer than 4032 bytes, the remaining part >> of the token must be copied from the rqstp->rq_arg.pages. But the >> copy must make sure it happens in a

Re: [PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-19 Thread J. Bruce Fields
On Mon, Oct 19, 2020 at 01:42:27PM +0200, Martijn de Gouw wrote: > When the passed token is longer than 4032 bytes, the remaining part > of the token must be copied from the rqstp->rq_arg.pages. But the > copy must make sure it happens in a consecutive way. Thanks. Apologies, but I don't

[PATCH] SUNRPC: fix copying of multiple pages in gss_read_proxy_verf()

2020-10-19 Thread Martijn de Gouw
When the passed token is longer than 4032 bytes, the remaining part of the token must be copied from the rqstp->rq_arg.pages. But the copy must make sure it happens in a consecutive way. Signed-off-by: Martijn de Gouw --- net/sunrpc/auth_gss/svcauth_gss.c | 27 +-- 1