Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-12 Thread Artem Bityutskiy
S.Çağlar Onur wrote: Hi; 10 Şub 2008 Paz tarihinde, Jiri Slaby şunları yazmıştı: I think this is not correct. You change the err which caused the failure. You change it even to 0 if it doesn't fail and the whole function will seem like non-failing. My bad, sorry for not looking carefully.

Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-12 Thread Artem Bityutskiy
S.Çağlar Onur wrote: Hi; 10 Şub 2008 Paz tarihinde, Jiri Slaby şunları yazmıştı: I think this is not correct. You change the err which caused the failure. You change it even to 0 if it doesn't fail and the whole function will seem like non-failing. My bad, sorry for not looking carefully.

Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-10 Thread S.Çağlar Onur
Hi; 10 Şub 2008 Paz tarihinde, Jiri Slaby şunları yazmıştı: > I think this is not correct. You change the err which caused the failure. You > change it even to 0 if it doesn't fail and the whole function will seem like > non-failing. My bad, sorry for not looking carefully. Assuming a

Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-10 Thread Jiri Slaby
On 02/10/2008 04:37 AM, S.Çağlar Onur wrote: Hi; Following patch silents drivers/mtd/ubi/vmt.c: In function `ubi_create_volume': drivers/mtd/ubi/vmt.c:379: warning: statement with no effect compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block

Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-10 Thread Jiri Slaby
On 02/10/2008 04:37 AM, S.Çağlar Onur wrote: Hi; Following patch silents drivers/mtd/ubi/vmt.c: In function `ubi_create_volume': drivers/mtd/ubi/vmt.c:379: warning: statement with no effect compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block

Re: [PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-10 Thread S.Çağlar Onur
Hi; 10 Şub 2008 Paz tarihinde, Jiri Slaby şunları yazmıştı: I think this is not correct. You change the err which caused the failure. You change it even to 0 if it doesn't fail and the whole function will seem like non-failing. My bad, sorry for not looking carefully. Assuming a

[PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-09 Thread S.Çağlar Onur
Hi; Following patch silents drivers/mtd/ubi/vmt.c: In function `ubi_create_volume': drivers/mtd/ubi/vmt.c:379: warning: statement with no effect compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images) Signed-off-by: S.Çağlar Onur <[EMAIL

[PATCH] Silent compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images)

2008-02-09 Thread S.Çağlar Onur
Hi; Following patch silents drivers/mtd/ubi/vmt.c: In function `ubi_create_volume': drivers/mtd/ubi/vmt.c:379: warning: statement with no effect compiler warning introduced by commit 801c135ce73d5df1caf3eca35b66a10824ae0707 (UBI: Unsorted Block Images) Signed-off-by: S.Çağlar Onur [EMAIL