Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Casey Schaufler
On 11/30/2012 2:01 PM, Eric Paris wrote: > Do other LSMs need this too Casey? I remember we mentioned how select > was dangerous :-( I don't see any missing dependencies, but then, I missed INET. Yes, you mentioned that it was dangerous. > > On Fri, Nov 30, 2012 at 12:28 PM, Casey Schaufler >

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Eric Paris
Do other LSMs need this too Casey? I remember we mentioned how select was dangerous :-( On Fri, Nov 30, 2012 at 12:28 PM, Casey Schaufler wrote: > Because NETLABEL depends on INET SECURITY_SMACK > has to explicitly call out the dependency. > > Signed-off-by: Casey Schaufler > --- >

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Casey Schaufler
On 11/30/2012 10:43 AM, David Miller wrote: > From: Randy Dunlap > Date: Fri, 30 Nov 2012 09:40:09 -0800 > >> On 11/30/2012 09:28 AM, Casey Schaufler wrote: >> >>> Because NETLABEL depends on INET SECURITY_SMACK >>> has to explicitly call out the dependency. >>> >>> Signed-off-by: Casey Schaufler

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Paul Moore
On Friday, November 30, 2012 09:40:09 AM Randy Dunlap wrote: > On 11/30/2012 09:28 AM, Casey Schaufler wrote: > > Because NETLABEL depends on INET SECURITY_SMACK > > has to explicitly call out the dependency. > > > > Signed-off-by: Casey Schaufler > > Acked-by: Randy Dunlap > > Thanks for the

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread David Miller
From: Randy Dunlap Date: Fri, 30 Nov 2012 09:40:09 -0800 > On 11/30/2012 09:28 AM, Casey Schaufler wrote: > >> Because NETLABEL depends on INET SECURITY_SMACK >> has to explicitly call out the dependency. >> >> Signed-off-by: Casey Schaufler > > > Acked-by: Randy Dunlap > > Thanks for the

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Randy Dunlap
On 11/30/2012 09:28 AM, Casey Schaufler wrote: > Because NETLABEL depends on INET SECURITY_SMACK > has to explicitly call out the dependency. > > Signed-off-by: Casey Schaufler Acked-by: Randy Dunlap Thanks for the quick fix. > --- > security/smack/Kconfig |1 + > 1 file changed, 1

[PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Casey Schaufler
Because NETLABEL depends on INET SECURITY_SMACK has to explicitly call out the dependency. Signed-off-by: Casey Schaufler --- security/smack/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/security/smack/Kconfig b/security/smack/Kconfig index 9fb14ef..1be1088 100644 ---

[PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Casey Schaufler
Because NETLABEL depends on INET SECURITY_SMACK has to explicitly call out the dependency. Signed-off-by: Casey Schaufler ca...@schaufler-ca.com --- security/smack/Kconfig |1 + 1 file changed, 1 insertion(+) diff --git a/security/smack/Kconfig b/security/smack/Kconfig index

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Randy Dunlap
On 11/30/2012 09:28 AM, Casey Schaufler wrote: Because NETLABEL depends on INET SECURITY_SMACK has to explicitly call out the dependency. Signed-off-by: Casey Schaufler ca...@schaufler-ca.com Acked-by: Randy Dunlap rdun...@xenotime.net Thanks for the quick fix. ---

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread David Miller
From: Randy Dunlap rdun...@xenotime.net Date: Fri, 30 Nov 2012 09:40:09 -0800 On 11/30/2012 09:28 AM, Casey Schaufler wrote: Because NETLABEL depends on INET SECURITY_SMACK has to explicitly call out the dependency. Signed-off-by: Casey Schaufler ca...@schaufler-ca.com Acked-by:

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Paul Moore
On Friday, November 30, 2012 09:40:09 AM Randy Dunlap wrote: On 11/30/2012 09:28 AM, Casey Schaufler wrote: Because NETLABEL depends on INET SECURITY_SMACK has to explicitly call out the dependency. Signed-off-by: Casey Schaufler ca...@schaufler-ca.com Acked-by: Randy Dunlap

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Casey Schaufler
On 11/30/2012 10:43 AM, David Miller wrote: From: Randy Dunlap rdun...@xenotime.net Date: Fri, 30 Nov 2012 09:40:09 -0800 On 11/30/2012 09:28 AM, Casey Schaufler wrote: Because NETLABEL depends on INET SECURITY_SMACK has to explicitly call out the dependency. Signed-off-by: Casey

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Eric Paris
Do other LSMs need this too Casey? I remember we mentioned how select was dangerous :-( On Fri, Nov 30, 2012 at 12:28 PM, Casey Schaufler ca...@schaufler-ca.com wrote: Because NETLABEL depends on INET SECURITY_SMACK has to explicitly call out the dependency. Signed-off-by: Casey Schaufler

Re: [PATCH] Smack: Add missing depends on INET in Kconfig

2012-11-30 Thread Casey Schaufler
On 11/30/2012 2:01 PM, Eric Paris wrote: Do other LSMs need this too Casey? I remember we mentioned how select was dangerous :-( I don't see any missing dependencies, but then, I missed INET. Yes, you mentioned that it was dangerous. On Fri, Nov 30, 2012 at 12:28 PM, Casey Schaufler