Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-07 Thread Darren Hart
On Thu, Feb 05, 2015 at 02:49:41PM +, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch fixes following sparse warning: > > sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. > Should it be static? > > Signed-off-by: Lad, Prabhakar Queued, thanks Lad.

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-07 Thread Darren Hart
On Sat, Feb 07, 2015 at 12:33:16PM +0100, Bjørn Mork wrote: > Darren Hart writes: > > On Thu, Feb 05, 2015 at 04:00:32PM +, Lad, Prabhakar wrote: > > > >> Lad, Prabhakar > >> Lad, Prabhakar > > > > I think there may be a problem with this in an unquoted email address. The > > unquoted local

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-07 Thread Bjørn Mork
Darren Hart writes: > On Thu, Feb 05, 2015 at 04:00:32PM +, Lad, Prabhakar wrote: > >> Lad, Prabhakar >> Lad, Prabhakar > > I think there may be a problem with this in an unquoted email address. The > unquoted local part, per RFC 2822 3.4.1, can only contain !#$%'*+-/=?^_`{|}~ > and .

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-07 Thread Bjørn Mork
Darren Hart dvh...@infradead.org writes: On Thu, Feb 05, 2015 at 04:00:32PM +, Lad, Prabhakar wrote: Lad, Prabhakar prabhakar@ti.com Lad, Prabhakar prabhakar.cse...@gmail.com I think there may be a problem with this in an unquoted email address. The unquoted local part, per RFC 2822

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-07 Thread Darren Hart
On Sat, Feb 07, 2015 at 12:33:16PM +0100, Bjørn Mork wrote: Darren Hart dvh...@infradead.org writes: On Thu, Feb 05, 2015 at 04:00:32PM +, Lad, Prabhakar wrote: Lad, Prabhakar prabhakar@ti.com Lad, Prabhakar prabhakar.cse...@gmail.com I think there may be a problem with this

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-07 Thread Darren Hart
On Thu, Feb 05, 2015 at 02:49:41PM +, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warning: sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-06 Thread Darren Hart
On Thu, Feb 05, 2015 at 04:00:32PM +, Lad, Prabhakar wrote: > Hi Giedrius, > > On Thu, Feb 5, 2015 at 3:55 PM, Giedrius Statkevičius > wrote: > > On 2015.02.05 16:49, Lad Prabhakar wrote: > >> From: "Lad, Prabhakar" > >> > >> this patch fixes following sparse warning: > >> > >>

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-06 Thread Darren Hart
On Thu, Feb 05, 2015 at 04:00:32PM +, Lad, Prabhakar wrote: Hi Giedrius, On Thu, Feb 5, 2015 at 3:55 PM, Giedrius Statkevičius giedrius.statkevic...@gmail.com wrote: On 2015.02.05 16:49, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-05 Thread Lad, Prabhakar
Hi Giedrius, On Thu, Feb 5, 2015 at 3:55 PM, Giedrius Statkevičius wrote: > On 2015.02.05 16:49, Lad Prabhakar wrote: >> From: "Lad, Prabhakar" >> >> this patch fixes following sparse warning: >> >> sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. >> Should it be

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-05 Thread Giedrius Statkevičius
On 2015.02.05 16:49, Lad Prabhakar wrote: > From: "Lad, Prabhakar" > > this patch fixes following sparse warning: > > sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. > Should it be static? > > Signed-off-by: Lad, Prabhakar Don't put a comma between your first and

[PATCH] Sony-laptop: fix sparse warning

2015-02-05 Thread Lad Prabhakar
From: "Lad, Prabhakar" this patch fixes following sparse warning: sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar --- Found this issue on linux-next (gcc version 4.9.2, sparse version 0.4.5-rc1) and applies on

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-05 Thread Lad, Prabhakar
Hi Giedrius, On Thu, Feb 5, 2015 at 3:55 PM, Giedrius Statkevičius giedrius.statkevic...@gmail.com wrote: On 2015.02.05 16:49, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warning: sony-laptop.c:1035:29: warning: symbol

Re: [PATCH] Sony-laptop: fix sparse warning

2015-02-05 Thread Giedrius Statkevičius
On 2015.02.05 16:49, Lad Prabhakar wrote: From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warning: sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com

[PATCH] Sony-laptop: fix sparse warning

2015-02-05 Thread Lad Prabhakar
From: Lad, Prabhakar prabhakar.cse...@gmail.com this patch fixes following sparse warning: sony-laptop.c:1035:29: warning: symbol 'sony_bl_props' was not declared. Should it be static? Signed-off-by: Lad, Prabhakar prabhakar.cse...@gmail.com --- Found this issue on linux-next (gcc version