Re: [PATCH] Staging: Android: logger: module_exit implementationg

2012-11-04 Thread Ryan Mallon
On 04/11/12 04:45, Luca Clementi wrote: > On Fri, Nov 2, 2012 at 11:29 AM, Greg Kroah-Hartman > wrote: >> On Thu, Nov 01, 2012 at 11:15:52PM -0700, Luca Clementi wrote: >>> + vfree(current_log->buffer); >>> + kfree(current_log->misc.name); >>> + kfree(current

Re: [PATCH] Staging: Android: logger: module_exit implementationg

2012-11-03 Thread Luca Clementi
On Fri, Nov 2, 2012 at 11:29 AM, Greg Kroah-Hartman wrote: > On Thu, Nov 01, 2012 at 11:15:52PM -0700, Luca Clementi wrote: >> Created the module_exit for the android logger so that >> it can be loaded and unloaded as a module. Fixed >> module_init and some other minor issues. > > That's doing mor

Re: [PATCH] Staging: Android: logger: module_exit implementationg

2012-11-02 Thread Brian Swetland
On Fri, Nov 2, 2012 at 11:29 AM, Greg Kroah-Hartman wrote: > On Thu, Nov 01, 2012 at 11:15:52PM -0700, Luca Clementi wrote: >> + >> + >> +module_init(logger_init); > > Is module_init() the same "level" as device_initcall()? Did you test > this out in an Android system? > >> +module_exit(logger_ex

Re: [PATCH] Staging: Android: logger: module_exit implementationg

2012-11-02 Thread Greg Kroah-Hartman
On Thu, Nov 01, 2012 at 11:15:52PM -0700, Luca Clementi wrote: > Created the module_exit for the android logger so that > it can be loaded and unloaded as a module. Fixed > module_init and some other minor issues. That's doing more than one thing here at once, care to break it up? Yeah, I know it