Re: [PATCH] Staging: android: binder: Fix over-80-char lines

2014-05-31 Thread Daniel Dressler
Thank you Neil I was not sure if space-based alignment was allowed so thank you for demonstrating the change. It does make the code much easier to read. Similar thank you for how to indent over-long function calls. I had mis-understood the coding standard to mean overflow needed to be on the far

Re: [PATCH] Staging: android: binder: Fix over-80-char lines

2014-05-30 Thread Dan Carpenter
What Neil said. On Fri, May 30, 2014 at 10:31:20PM -0600, Daniel Dressler wrote: > From: danieru This is wrong and we also get your name and email address from the email headers so leave this line out. > > Following Greg Kroah-Hartman's newbie guide to hacking > the linux kernel this patch add

Re: [PATCH] Staging: android: binder: Fix over-80-char lines

2014-05-30 Thread NeilBrown
On Fri, 30 May 2014 22:31:20 -0600 Daniel Dressler wrote: > From: danieru > > Following Greg Kroah-Hartman's newbie guide to hacking > the linux kernel this patch addresses only coding style > issues. > > Binder still has many too-long lines but I'm worried > doing too much work in a single pa

[PATCH] Staging: android: binder: Fix over-80-char lines

2014-05-30 Thread Daniel Dressler
From: danieru Following Greg Kroah-Hartman's newbie guide to hacking the linux kernel this patch addresses only coding style issues. Binder still has many too-long lines but I'm worried doing too much work in a single patch is unfair to the reviewers. So this patch address 20% of the file's issu