On Mon, 2014-02-24 at 19:39 +1100, David Roddick wrote:
> This is a patch to remove unneccessary space after function pointer name
> found with checkpatch.pl
A few comments:
Please wrap your commit message to 70 columns or so.
There is 1 c in unnecessary.
The "This is a patch to " bit isn't
This is a patch to remove unneccessary space after function pointer name found
with checkpatch.pl
Signed-off-by: David Roddick
---
drivers/staging/comedi/drivers/poc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/poc.c
Subject is still messed up. Send the email to yourself first and then
to the list until you figure it out. (hint add a blank line).
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More
Subject is still messed up. Send the email to yourself first and then
to the list until you figure it out. (hint add a blank line).
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More
This is a patch to remove unneccessary space after function pointer name found
with checkpatch.pl
Signed-off-by: David Roddick dgrodd...@gmail.com
---
drivers/staging/comedi/drivers/poc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git
On Mon, 2014-02-24 at 19:39 +1100, David Roddick wrote:
This is a patch to remove unneccessary space after function pointer name
found with checkpatch.pl
A few comments:
Please wrap your commit message to 70 columns or so.
There is 1 c in unnecessary.
The This is a patch to bit isn't
Signed-off-by: David Roddick
---
drivers/staging/comedi/drivers/poc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/poc.c
b/drivers/staging/comedi/drivers/poc.c
index 2ae4ee1..22c7392 100644
--- a/drivers/staging/comedi/drivers/poc.c
Leave a blank line between the subject and the body of the changelog.
The signed-off-by line is missing.
regards,
dan carpenter
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at
---
drivers/staging/comedi/drivers/poc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/poc.c
b/drivers/staging/comedi/drivers/poc.c
index 2ae4ee1..22c7392 100644
--- a/drivers/staging/comedi/drivers/poc.c
+++
---
drivers/staging/comedi/drivers/poc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/poc.c
b/drivers/staging/comedi/drivers/poc.c
index 2ae4ee1..22c7392 100644
--- a/drivers/staging/comedi/drivers/poc.c
+++
---
drivers/staging/comedi/drivers/poc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/poc.c
b/drivers/staging/comedi/drivers/poc.c
index 2ae4ee1..22c7392 100644
--- a/drivers/staging/comedi/drivers/poc.c
+++
---
drivers/staging/comedi/drivers/poc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/poc.c
b/drivers/staging/comedi/drivers/poc.c
index 2ae4ee1..22c7392 100644
--- a/drivers/staging/comedi/drivers/poc.c
+++
Leave a blank line between the subject and the body of the changelog.
The signed-off-by line is missing.
regards,
dan carpenter
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at
Signed-off-by: David Roddick dgrodd...@gmail.com
---
drivers/staging/comedi/drivers/poc.c | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/drivers/staging/comedi/drivers/poc.c
b/drivers/staging/comedi/drivers/poc.c
index 2ae4ee1..22c7392 100644
---
14 matches
Mail list logo