Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread g...@kroah.com
On Mon, Nov 27, 2017 at 05:51:56PM +, Hartley Sweeten wrote: > On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: > >> + const struct comedi_lrange *lrange; > > > > NAK. The following lines of source code allocate memory

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread g...@kroah.com
On Mon, Nov 27, 2017 at 05:51:56PM +, Hartley Sweeten wrote: > On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: > >> + const struct comedi_lrange *lrange; > > > > NAK. The following lines of source code allocate memory

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread kbuild test robot
Hi Alex, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.15-rc1 next-20171127] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread kbuild test robot
Hi Alex, Thank you for the patch! Yet something to improve: [auto build test ERROR on staging/staging-testing] [also build test ERROR on v4.15-rc1 next-20171127] [if your patch is applied to the wrong git tree, please drop us a note to help improve the system] url:

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread Dan Carpenter
On Mon, Nov 27, 2017 at 05:51:56PM +, Hartley Sweeten wrote: > On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: > >> + const struct comedi_lrange *lrange; > > > > NAK. The following lines of source code allocate memory

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread Dan Carpenter
On Mon, Nov 27, 2017 at 05:51:56PM +, Hartley Sweeten wrote: > On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: > >> + const struct comedi_lrange *lrange; > > > > NAK. The following lines of source code allocate memory

RE: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread Hartley Sweeten
On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: >> +const struct comedi_lrange *lrange; > > NAK. The following lines of source code allocate memory pointed to by > 'lrange' and modify it, so 'const' is not appropriate here.

RE: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread Hartley Sweeten
On Monday, November 27, 2017 3:28 AM, Ian Abbott wrote: > On 26/11/17 01:50, Alex Frappier Lachapelle wrote: >> +const struct comedi_lrange *lrange; > > NAK. The following lines of source code allocate memory pointed to by > 'lrange' and modify it, so 'const' is not appropriate here.

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread Ian Abbott
On 26/11/17 01:50, Alex Frappier Lachapelle wrote: Fixed a coding style issue. Signed-off-by: Alex Frappier Lachapelle --- drivers/staging/comedi/drivers/das16.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git

Re: [PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-27 Thread Ian Abbott
On 26/11/17 01:50, Alex Frappier Lachapelle wrote: Fixed a coding style issue. Signed-off-by: Alex Frappier Lachapelle --- drivers/staging/comedi/drivers/das16.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c

[PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-25 Thread Alex Frappier Lachapelle
Fixed a coding style issue. Signed-off-by: Alex Frappier Lachapelle --- drivers/staging/comedi/drivers/das16.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c

[PATCH] Staging: comedi: das16: Fixed a const struct coding style issue

2017-11-25 Thread Alex Frappier Lachapelle
Fixed a coding style issue. Signed-off-by: Alex Frappier Lachapelle --- drivers/staging/comedi/drivers/das16.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/staging/comedi/drivers/das16.c b/drivers/staging/comedi/drivers/das16.c index