On Tue, Mar 03, 2015 at 08:04:10PM +0100, Noralf Trønnes wrote:
> These functions are defined in fbtft-sysfs.c and internal to the
> fbtft module.
> I think it's better to put them in an 'internal.h' file.
> The fbtft.h file will eventually live in include/linux/fbtft.h or
> something like that.
T
Den 03.03.2015 11:19, skrev Drew Fustini:
Move extern declartions from fbtft-core.c to fbtft header file. This resovles
the warning from checkpatch.pl that "externs should be avoided in .c files".
Signed-off-by: Drew Fustini
---
drivers/staging/fbtft/fbtft-core.c | 5 -
drivers/staging/
On Tue, Mar 03, 2015 at 04:33:01PM +0530, Sudip Mukherjee wrote:
> but now it adds 6 additional warning in checkpatch --strict
> "extern prototypes should be avoided in .h files"
Thanks, Sudip. I did not realize that was an option for checkpatch.
I see now that there are additional warnings as yo
On Tue, Mar 03, 2015 at 04:19:17AM -0600, Drew Fustini wrote:
> Move extern declartions from fbtft-core.c to fbtft header file. This resovles
> the warning from checkpatch.pl that "externs should be avoided in .c files".
but now it adds 6 additional warning in checkpatch --strict
"extern prototype
Move extern declartions from fbtft-core.c to fbtft header file. This resovles
the warning from checkpatch.pl that "externs should be avoided in .c files".
Signed-off-by: Drew Fustini
---
drivers/staging/fbtft/fbtft-core.c | 5 -
drivers/staging/fbtft/fbtft.h | 7 +++
2 files changed
5 matches
Mail list logo