Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-04 Thread Jens Frederich
On Sun, Aug 4, 2013 at 1:14 AM, Dan Carpenter wrote: > On Sat, Aug 03, 2013 at 10:44:35PM +0200, Jens Frederich wrote: >> @@ -126,7 +127,7 @@ static int dcon_bus_stabilize(struct dcon_priv *dcon, >> int is_powered_down) >> power_up: >> if (is_powered_down) { >> x = 1; >> -

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-04 Thread Jens Frederich
On Sun, Aug 4, 2013 at 5:57 AM, Jon Nettleton wrote: > > On Aug 3, 2013 11:38 PM, "Andres Salomon" wrote: >> >> On Sat, 3 Aug 2013 23:36:15 +0200 >> Jens Frederich wrote: >> >> > On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon >> > wrote: >> > > Please Cc Daniel on these. Cjb and myself are

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-04 Thread Jens Frederich
On Sun, Aug 4, 2013 at 5:57 AM, Jon Nettleton jon.nettle...@gmail.com wrote: On Aug 3, 2013 11:38 PM, Andres Salomon dilin...@queued.net wrote: On Sat, 3 Aug 2013 23:36:15 +0200 Jens Frederich jfreder...@gmail.com wrote: On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon dilin...@queued.net

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-04 Thread Jens Frederich
On Sun, Aug 4, 2013 at 1:14 AM, Dan Carpenter dan.carpen...@oracle.com wrote: On Sat, Aug 03, 2013 at 10:44:35PM +0200, Jens Frederich wrote: @@ -126,7 +127,7 @@ static int dcon_bus_stabilize(struct dcon_priv *dcon, int is_powered_down) power_up: if (is_powered_down) {

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Dan Carpenter
On Sat, Aug 03, 2013 at 02:38:45PM -0700, Andres Salomon wrote: > On Sat, 3 Aug 2013 23:36:15 +0200 > Jens Frederich wrote: > > > On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon > > wrote: > > > Please Cc Daniel on these. Cjb and myself are no longer at olpc. > > > > > > > Do you know what's

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Dan Carpenter
On Sat, Aug 03, 2013 at 10:44:35PM +0200, Jens Frederich wrote: > @@ -126,7 +127,7 @@ static int dcon_bus_stabilize(struct dcon_priv *dcon, int > is_powered_down) > power_up: > if (is_powered_down) { > x = 1; > - x = olpc_ec_cmd(0x26, (unsigned char *), 1, NULL,

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Andres Salomon
On Sat, 3 Aug 2013 23:36:15 +0200 Jens Frederich wrote: > On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon > wrote: > > Please Cc Daniel on these. Cjb and myself are no longer at olpc. > > > > Do you know what's with Jon Nettleton? He is also on the TODO list? Let's ask. Jon, do you still

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Jens Frederich
On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon wrote: > Please Cc Daniel on these. Cjb and myself are no longer at olpc. > Do you know what's with Jon Nettleton? He is also on the TODO list? -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Jens Frederich
On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon wrote: > Please Cc Daniel on these. Cjb and myself are no longer at olpc. > Sorry, I've forgotten it. I will update the the TODO list. -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Andres Salomon
Please Cc Daniel on these. Cjb and myself are no longer at olpc. On Sat, 3 Aug 2013 22:44:35 +0200 Jens Frederich wrote: > This patch replace some magic numbers. I believe it makes > the driver more readable. > > The magic number 0x26 is the XO system embedded controller > (EC) command

[PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Jens Frederich
This patch replace some magic numbers. I believe it makes the driver more readable. The magic number 0x26 is the XO system embedded controller (EC) command 'DCON power enable/disable'. Number 0x41, and 0x42 are special memory controller settings register. The 0x41 initialize bit sequence 0x101

[PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Jens Frederich
This patch replace some magic numbers. I believe it makes the driver more readable. The magic number 0x26 is the XO system embedded controller (EC) command 'DCON power enable/disable'. Number 0x41, and 0x42 are special memory controller settings register. The 0x41 initialize bit sequence 0x101

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Andres Salomon
Please Cc Daniel on these. Cjb and myself are no longer at olpc. On Sat, 3 Aug 2013 22:44:35 +0200 Jens Frederich jfreder...@gmail.com wrote: This patch replace some magic numbers. I believe it makes the driver more readable. The magic number 0x26 is the XO system embedded controller

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Jens Frederich
On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon dilin...@queued.net wrote: Please Cc Daniel on these. Cjb and myself are no longer at olpc. Sorry, I've forgotten it. I will update the the TODO list. -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Jens Frederich
On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon dilin...@queued.net wrote: Please Cc Daniel on these. Cjb and myself are no longer at olpc. Do you know what's with Jon Nettleton? He is also on the TODO list? -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Andres Salomon
On Sat, 3 Aug 2013 23:36:15 +0200 Jens Frederich jfreder...@gmail.com wrote: On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon dilin...@queued.net wrote: Please Cc Daniel on these. Cjb and myself are no longer at olpc. Do you know what's with Jon Nettleton? He is also on the TODO list?

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Dan Carpenter
On Sat, Aug 03, 2013 at 10:44:35PM +0200, Jens Frederich wrote: @@ -126,7 +127,7 @@ static int dcon_bus_stabilize(struct dcon_priv *dcon, int is_powered_down) power_up: if (is_powered_down) { x = 1; - x = olpc_ec_cmd(0x26, (unsigned char *)x, 1, NULL, 0); +

Re: [PATCH] Staging: olpc_dcon: replace some magic numbers

2013-08-03 Thread Dan Carpenter
On Sat, Aug 03, 2013 at 02:38:45PM -0700, Andres Salomon wrote: On Sat, 3 Aug 2013 23:36:15 +0200 Jens Frederich jfreder...@gmail.com wrote: On Sat, Aug 3, 2013 at 11:16 PM, Andres Salomon dilin...@queued.net wrote: Please Cc Daniel on these. Cjb and myself are no longer at olpc.