Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-27 Thread Bogicevic Sasa
Thanks, I get it now, Ill will group all changes and resend the patches On 10/27/2015, Greg KH wrote: On Mon, Oct 26, 2015 at 11:21:48PM +0100, Bogicevic Sasa wrote: On 10/26, Bogicevic Sasa wrote: >Thanks for the review just sent the new patch, >since change is very trivial I believe one liner

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-27 Thread Greg KH
On Mon, Oct 26, 2015 at 05:36:55PM +0100, Bogicevic Sasa wrote: > Fixed coding style issues > Signed-off-by: Bogicevic Sasa > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 189 > +- > 1 file changed, 95 insertions(+), 94 deletions(-) And again, please break

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-27 Thread Greg KH
On Mon, Oct 26, 2015 at 05:36:55PM +0100, Bogicevic Sasa wrote: > Fixed coding style issues > Signed-off-by: Bogicevic Sasa > --- > drivers/staging/wlan-ng/hfa384x_usb.c | 189 > +- > 1 file changed, 95 insertions(+), 94 deletions(-) And

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-27 Thread Bogicevic Sasa
Thanks, I get it now, Ill will group all changes and resend the patches On 10/27/2015, Greg KH wrote: On Mon, Oct 26, 2015 at 11:21:48PM +0100, Bogicevic Sasa wrote: On 10/26, Bogicevic Sasa wrote: >Thanks for the review just sent the new patch, >since change is very trivial I believe one liner

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-26 Thread Greg KH
On Mon, Oct 26, 2015 at 11:21:48PM +0100, Bogicevic Sasa wrote: > On 10/26, Bogicevic Sasa wrote: > >Thanks for the review just sent the new patch, > >since change is very trivial I believe one liner like "fix all coding > >style issues in that and that file" is descriptive enough. No, not at

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-26 Thread Bogicevic Sasa
On 10/26, Bogicevic Sasa wrote: Thanks for the review just sent the new patch, since change is very trivial I believe one liner like "fix all coding style issues in that and that file" is descriptive enough. Don't know the best practice so please be patient, I am new at this On 10/27, Greg KH

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-26 Thread Bogicevic Sasa
yup, my bad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-26 Thread Greg KH
On Mon, Oct 26, 2015 at 05:36:55PM +0100, Bogicevic Sasa wrote: > Fixed coding style issues > Signed-off-by: Bogicevic Sasa What code style issues? Please be very specific. Also be sure you are only doing one "thing" per patch, and no, "fix all coding style issues" is not one thing... And we

[PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-26 Thread Bogicevic Sasa
Fixed coding style issues Signed-off-by: Bogicevic Sasa --- drivers/staging/wlan-ng/hfa384x_usb.c | 189 +- 1 file changed, 95 insertions(+), 94 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c b/drivers/staging/wlan-ng/hfa384x_usb.c index

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-26 Thread Bogicevic Sasa
yup, my bad -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-26 Thread Greg KH
On Mon, Oct 26, 2015 at 05:36:55PM +0100, Bogicevic Sasa wrote: > Fixed coding style issues > Signed-off-by: Bogicevic Sasa What code style issues? Please be very specific. Also be sure you are only doing one "thing" per patch, and no, "fix all coding style issues" is

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-26 Thread Greg KH
On Mon, Oct 26, 2015 at 11:21:48PM +0100, Bogicevic Sasa wrote: > On 10/26, Bogicevic Sasa wrote: > >Thanks for the review just sent the new patch, > >since change is very trivial I believe one liner like "fix all coding > >style issues in that and that file" is descriptive enough. No, not at

Re: [PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-26 Thread Bogicevic Sasa
On 10/26, Bogicevic Sasa wrote: Thanks for the review just sent the new patch, since change is very trivial I believe one liner like "fix all coding style issues in that and that file" is descriptive enough. Don't know the best practice so please be patient, I am new at this On 10/27, Greg KH

[PATCH] Staging:drivers:wlan_ng: code style issues

2015-10-26 Thread Bogicevic Sasa
Fixed coding style issues Signed-off-by: Bogicevic Sasa --- drivers/staging/wlan-ng/hfa384x_usb.c | 189 +- 1 file changed, 95 insertions(+), 94 deletions(-) diff --git a/drivers/staging/wlan-ng/hfa384x_usb.c