Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-04-17 Thread Greg KH
On Wed, Apr 17, 2013 at 09:54:24AM -0500, Kent Yoder wrote: > On Tue, Apr 16, 2013 at 6:57 PM, Greg KH wrote: > > On Tue, Mar 19, 2013 at 10:00:02AM -0500, Kent Yoder wrote: > >> Hi Duncan, > >> > >> On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie > >> wrote: > >> > If the TPM has already been

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-04-17 Thread Kent Yoder
On Tue, Apr 16, 2013 at 6:57 PM, Greg KH wrote: > On Tue, Mar 19, 2013 at 10:00:02AM -0500, Kent Yoder wrote: >> Hi Duncan, >> >> On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie wrote: >> > If the TPM has already been sent a SaveState command before the driver >> > is loaded it may have problems

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-04-17 Thread Kent Yoder
On Tue, Apr 16, 2013 at 6:57 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Mar 19, 2013 at 10:00:02AM -0500, Kent Yoder wrote: Hi Duncan, On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie dlau...@chromium.org wrote: If the TPM has already been sent a SaveState command before the driver

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-04-17 Thread Greg KH
On Wed, Apr 17, 2013 at 09:54:24AM -0500, Kent Yoder wrote: On Tue, Apr 16, 2013 at 6:57 PM, Greg KH gre...@linuxfoundation.org wrote: On Tue, Mar 19, 2013 at 10:00:02AM -0500, Kent Yoder wrote: Hi Duncan, On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie dlau...@chromium.org wrote: If

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-04-16 Thread Greg KH
On Tue, Mar 19, 2013 at 10:00:02AM -0500, Kent Yoder wrote: > Hi Duncan, > > On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie wrote: > > If the TPM has already been sent a SaveState command before the driver > > is loaded it may have problems sending that same command again later. > > > > This

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-04-16 Thread Greg KH
On Tue, Mar 19, 2013 at 10:00:02AM -0500, Kent Yoder wrote: Hi Duncan, On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie dlau...@chromium.org wrote: If the TPM has already been sent a SaveState command before the driver is loaded it may have problems sending that same command again later.

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-03-19 Thread Kent Yoder
Hi Duncan, On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie wrote: > If the TPM has already been sent a SaveState command before the driver > is loaded it may have problems sending that same command again later. > > This issue is seen with the Chromebook Pixel due to a firmware bug in > the legacy

Re: [PATCH] TPM: Retry SaveState command in suspend path

2013-03-19 Thread Kent Yoder
Hi Duncan, On Sun, Mar 17, 2013 at 4:56 PM, Duncan Laurie dlau...@chromium.org wrote: If the TPM has already been sent a SaveState command before the driver is loaded it may have problems sending that same command again later. This issue is seen with the Chromebook Pixel due to a firmware bug

RE: [tpmdd-devel] [PATCH] TPM: Retry SaveState command in suspend path

2013-03-18 Thread Peter.Huewe
Hi > The TPM is too busy to respond to the command immediately, but the > command could be resubmitted at a later time. The TPM MAY return > TPM_RETRY for any command at any time. > It can take several seconds before the TPM will respond again. I measured a > typical time between 3 and 4

RE: [tpmdd-devel] [PATCH] TPM: Retry SaveState command in suspend path

2013-03-18 Thread Peter.Huewe
Hi The TPM is too busy to respond to the command immediately, but the command could be resubmitted at a later time. The TPM MAY return TPM_RETRY for any command at any time. It can take several seconds before the TPM will respond again. I measured a typical time between 3 and 4

[PATCH] TPM: Retry SaveState command in suspend path

2013-03-17 Thread Duncan Laurie
If the TPM has already been sent a SaveState command before the driver is loaded it may have problems sending that same command again later. This issue is seen with the Chromebook Pixel due to a firmware bug in the legacy mode boot path which is sending the SaveState command before booting the

[PATCH] TPM: Retry SaveState command in suspend path

2013-03-17 Thread Duncan Laurie
If the TPM has already been sent a SaveState command before the driver is loaded it may have problems sending that same command again later. This issue is seen with the Chromebook Pixel due to a firmware bug in the legacy mode boot path which is sending the SaveState command before booting the