Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-20 Thread Ahmed S. Darwish
On Wed, Feb 20, 2008 at 03:20:52PM +0100, Dmitry Adamushko wrote: > On 20/02/2008, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > On Wed, Feb 20, 2008 at 11:41:13AM +0100, Ingo Molnar wrote: > > > > > > * Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > > > > > > > > -

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-20 Thread Dmitry Adamushko
On 20/02/2008, Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > On Wed, Feb 20, 2008 at 11:41:13AM +0100, Ingo Molnar wrote: > > > > * Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > > > > > > - local_irq_disable(); > > > > > - t->next = __get_cpu_var(tasklet_vec).list; >

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-20 Thread Ahmed S. Darwish
On Wed, Feb 20, 2008 at 11:41:13AM +0100, Ingo Molnar wrote: > > * Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > > > > - local_irq_disable(); > > > > - t->next = __get_cpu_var(tasklet_vec).list; > > > > - __get_cpu_var(tasklet_vec).list = t; > > > > -

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-20 Thread Ingo Molnar
* Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > > - local_irq_disable(); > > > - t->next = __get_cpu_var(tasklet_vec).list; > > > - __get_cpu_var(tasklet_vec).list = t; > > > - __raise_softirq_irqoff(TASKLET_SOFTIRQ); > > > - local_irq_enable(); > > > +

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-20 Thread Ingo Molnar
* Ahmed S. Darwish [EMAIL PROTECTED] wrote: - local_irq_disable(); - t-next = __get_cpu_var(tasklet_vec).list; - __get_cpu_var(tasklet_vec).list = t; - __raise_softirq_irqoff(TASKLET_SOFTIRQ); - local_irq_enable(); + /* We were

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-20 Thread Ahmed S. Darwish
On Wed, Feb 20, 2008 at 11:41:13AM +0100, Ingo Molnar wrote: * Ahmed S. Darwish [EMAIL PROTECTED] wrote: - local_irq_disable(); - t-next = __get_cpu_var(tasklet_vec).list; - __get_cpu_var(tasklet_vec).list = t; -

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-20 Thread Dmitry Adamushko
On 20/02/2008, Ahmed S. Darwish [EMAIL PROTECTED] wrote: On Wed, Feb 20, 2008 at 11:41:13AM +0100, Ingo Molnar wrote: * Ahmed S. Darwish [EMAIL PROTECTED] wrote: - local_irq_disable(); - t-next = __get_cpu_var(tasklet_vec).list; -

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-20 Thread Ahmed S. Darwish
On Wed, Feb 20, 2008 at 03:20:52PM +0100, Dmitry Adamushko wrote: On 20/02/2008, Ahmed S. Darwish [EMAIL PROTECTED] wrote: On Wed, Feb 20, 2008 at 11:41:13AM +0100, Ingo Molnar wrote: * Ahmed S. Darwish [EMAIL PROTECTED] wrote: - local_irq_disable(); -

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-19 Thread Ahmed S. Darwish
On Tue, Feb 19, 2008 at 04:52:52PM +0100, Ingo Molnar wrote: > > * Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > > > - local_irq_disable(); > > - t->next = __get_cpu_var(tasklet_vec).list; > > - __get_cpu_var(tasklet_vec).list = t; > > -

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-19 Thread Ingo Molnar
* Ahmed S. Darwish <[EMAIL PROTECTED]> wrote: > - local_irq_disable(); > - t->next = __get_cpu_var(tasklet_vec).list; > - __get_cpu_var(tasklet_vec).list = t; > - __raise_softirq_irqoff(TASKLET_SOFTIRQ); > - local_irq_enable(); > +

[PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-19 Thread Ahmed S. Darwish
Hi all, Avoid duplicating __tasklet_schedule() and __tasklet_hi_schedule() code in tasklet_action() and tasklet_hi_action() respectively. Signed-off-by: Ahmed S. Darwish <[EMAIL PROTECTED]> --- This also saves a few bytes of image space: textdata bss dec hex filename 3632

[PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-19 Thread Ahmed S. Darwish
Hi all, Avoid duplicating __tasklet_schedule() and __tasklet_hi_schedule() code in tasklet_action() and tasklet_hi_action() respectively. Signed-off-by: Ahmed S. Darwish [EMAIL PROTECTED] --- This also saves a few bytes of image space: textdata bss dec hex filename 3632

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-19 Thread Ahmed S. Darwish
On Tue, Feb 19, 2008 at 04:52:52PM +0100, Ingo Molnar wrote: * Ahmed S. Darwish [EMAIL PROTECTED] wrote: - local_irq_disable(); - t-next = __get_cpu_var(tasklet_vec).list; - __get_cpu_var(tasklet_vec).list = t; -

Re: [PATCH] Tasklets: Avoid duplicating __tasklet_{,hi_}schedule() code

2008-02-19 Thread Ingo Molnar
* Ahmed S. Darwish [EMAIL PROTECTED] wrote: - local_irq_disable(); - t-next = __get_cpu_var(tasklet_vec).list; - __get_cpu_var(tasklet_vec).list = t; - __raise_softirq_irqoff(TASKLET_SOFTIRQ); - local_irq_enable(); +