Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-11 Thread Artem Bityutskiy
On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: > Some cosmetic fixes to the patch "UBI: Extend UBI layer debug/messaging > capabilities". > > Signed-off-by: Tanya Brokhman > --- Pushed this patch, but without the hunk which changes the printing helpers. Thanks! -- To unsubscribe from

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-11 Thread Artem Bityutskiy
On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: Some cosmetic fixes to the patch UBI: Extend UBI layer debug/messaging capabilities. Signed-off-by: Tanya Brokhman tlin...@codeaurora.org --- Pushed this patch, but without the hunk which changes the printing helpers. Thanks! -- To

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-10 Thread Joe Perches
On Mon, 2014-11-10 at 15:14 +0200, Artem Bityutskiy wrote: > On Mon, 2014-11-10 at 14:53 +0200, Tanya Brokhman wrote: > > On 11/10/2014 2:18 PM, Artem Bityutskiy wrote: > > > On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: > > >> > > >> /* Normal UBI messages */ > > >> #define

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-10 Thread Richard Weinberger
On Mon, Nov 10, 2014 at 1:53 PM, Tanya Brokhman wrote: > On 11/10/2014 2:18 PM, Artem Bityutskiy wrote: >> >> On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: >>> >>> >>> /* Normal UBI messages */ >>> #define ubi_msg(ubi, fmt, ...) pr_notice("UBI-%d: %s:" fmt "\n", \ >>> -

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-10 Thread Artem Bityutskiy
On Mon, 2014-11-10 at 14:53 +0200, Tanya Brokhman wrote: > On 11/10/2014 2:18 PM, Artem Bityutskiy wrote: > > On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: > >> > >> /* Normal UBI messages */ > >> #define ubi_msg(ubi, fmt, ...) pr_notice("UBI-%d: %s:" fmt "\n", \ > >> -

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-10 Thread Tanya Brokhman
On 11/10/2014 2:18 PM, Artem Bityutskiy wrote: On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: /* Normal UBI messages */ #define ubi_msg(ubi, fmt, ...) pr_notice("UBI-%d: %s:" fmt "\n", \ -ubi->ubi_num, __func__, ##__VA_ARGS__) +

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-10 Thread Artem Bityutskiy
On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: > > /* Normal UBI messages */ > #define ubi_msg(ubi, fmt, ...) pr_notice("UBI-%d: %s:" fmt "\n", \ > -ubi->ubi_num, __func__, > ##__VA_ARGS__) > + (ubi ? ubi->ubi_num

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-10 Thread Artem Bityutskiy
On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: /* Normal UBI messages */ #define ubi_msg(ubi, fmt, ...) pr_notice(UBI-%d: %s: fmt \n, \ -ubi-ubi_num, __func__, ##__VA_ARGS__) + (ubi ? ubi-ubi_num :

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-10 Thread Tanya Brokhman
On 11/10/2014 2:18 PM, Artem Bityutskiy wrote: On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: /* Normal UBI messages */ #define ubi_msg(ubi, fmt, ...) pr_notice(UBI-%d: %s: fmt \n, \ -ubi-ubi_num, __func__, ##__VA_ARGS__) +

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-10 Thread Artem Bityutskiy
On Mon, 2014-11-10 at 14:53 +0200, Tanya Brokhman wrote: On 11/10/2014 2:18 PM, Artem Bityutskiy wrote: On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: /* Normal UBI messages */ #define ubi_msg(ubi, fmt, ...) pr_notice(UBI-%d: %s: fmt \n, \ -

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-10 Thread Richard Weinberger
On Mon, Nov 10, 2014 at 1:53 PM, Tanya Brokhman tlin...@codeaurora.org wrote: On 11/10/2014 2:18 PM, Artem Bityutskiy wrote: On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: /* Normal UBI messages */ #define ubi_msg(ubi, fmt, ...) pr_notice(UBI-%d: %s: fmt \n, \ -

Re: [PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-10 Thread Joe Perches
On Mon, 2014-11-10 at 15:14 +0200, Artem Bityutskiy wrote: On Mon, 2014-11-10 at 14:53 +0200, Tanya Brokhman wrote: On 11/10/2014 2:18 PM, Artem Bityutskiy wrote: On Sun, 2014-11-09 at 13:06 +0200, Tanya Brokhman wrote: /* Normal UBI messages */ #define ubi_msg(ubi, fmt, ...)

[PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-09 Thread Tanya Brokhman
Some cosmetic fixes to the patch "UBI: Extend UBI layer debug/messaging capabilities". Signed-off-by: Tanya Brokhman --- Changes from original patch: - Added ptr verification @ ubi_err/ubi_msg/ubi_warn Removed extra printing of ubi number Removed new messages.

[PATCH] UBI: Extend UBI layer debug/messaging capabilities - cosmetics

2014-11-09 Thread Tanya Brokhman
Some cosmetic fixes to the patch UBI: Extend UBI layer debug/messaging capabilities. Signed-off-by: Tanya Brokhman tlin...@codeaurora.org --- Changes from original patch: - Added ptr verification @ ubi_err/ubi_msg/ubi_warn Removed extra printing of ubi number Removed new