Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-17 Thread Geert Uytterhoeven
Hi Boris, On Mon, Oct 17, 2016 at 1:02 PM, Boris Brezillon wrote: > On Mon, 17 Oct 2016 10:00:25 +0200 > Geert Uytterhoeven wrote: >> On Thu, Oct 13, 2016 at 4:24 PM, Boris Brezillon >> wrote: >> > On

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-17 Thread Geert Uytterhoeven
Hi Boris, On Mon, Oct 17, 2016 at 1:02 PM, Boris Brezillon wrote: > On Mon, 17 Oct 2016 10:00:25 +0200 > Geert Uytterhoeven wrote: >> On Thu, Oct 13, 2016 at 4:24 PM, Boris Brezillon >> wrote: >> > On Thu, 13 Oct 2016 16:05:36 +0200 >> > Geert Uytterhoeven wrote: >> > >> >>

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-17 Thread Boris Brezillon
On Mon, 17 Oct 2016 10:00:25 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Thu, Oct 13, 2016 at 4:24 PM, Boris Brezillon > wrote: > > On Thu, 13 Oct 2016 16:05:36 +0200 > > Geert Uytterhoeven wrote: > > >

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-17 Thread Boris Brezillon
On Mon, 17 Oct 2016 10:00:25 +0200 Geert Uytterhoeven wrote: > Hi Boris, > > On Thu, Oct 13, 2016 at 4:24 PM, Boris Brezillon > wrote: > > On Thu, 13 Oct 2016 16:05:36 +0200 > > Geert Uytterhoeven wrote: > > > >> drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’: > >>

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-17 Thread Geert Uytterhoeven
Hi Boris, On Fri, Oct 14, 2016 at 12:49 PM, Boris Brezillon wrote: > On Thu, 13 Oct 2016 16:24:58 +0200 > Boris Brezillon wrote: >> On Thu, 13 Oct 2016 16:05:36 +0200 >> Geert Uytterhoeven wrote: >>

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-17 Thread Geert Uytterhoeven
Hi Boris, On Fri, Oct 14, 2016 at 12:49 PM, Boris Brezillon wrote: > On Thu, 13 Oct 2016 16:24:58 +0200 > Boris Brezillon wrote: >> On Thu, 13 Oct 2016 16:05:36 +0200 >> Geert Uytterhoeven wrote: >> >> > drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’: >> >

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-17 Thread Geert Uytterhoeven
Hi Boris, On Thu, Oct 13, 2016 at 4:24 PM, Boris Brezillon wrote: > On Thu, 13 Oct 2016 16:05:36 +0200 > Geert Uytterhoeven wrote: > >> drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’: >> drivers/mtd/ubi/eba.c:744: warning:

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-17 Thread Geert Uytterhoeven
Hi Boris, On Thu, Oct 13, 2016 at 4:24 PM, Boris Brezillon wrote: > On Thu, 13 Oct 2016 16:05:36 +0200 > Geert Uytterhoeven wrote: > >> drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’: >> drivers/mtd/ubi/eba.c:744: warning: ‘vid_hdr’ is used uninitialized in >> this function >> >>

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-14 Thread Boris Brezillon
On Thu, 13 Oct 2016 16:24:58 +0200 Boris Brezillon wrote: > Hi Geert, > > On Thu, 13 Oct 2016 16:05:36 +0200 > Geert Uytterhoeven wrote: > > > drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’: > > drivers/mtd/ubi/eba.c:744:

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-14 Thread Boris Brezillon
On Thu, 13 Oct 2016 16:24:58 +0200 Boris Brezillon wrote: > Hi Geert, > > On Thu, 13 Oct 2016 16:05:36 +0200 > Geert Uytterhoeven wrote: > > > drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’: > > drivers/mtd/ubi/eba.c:744: warning: ‘vid_hdr’ is used uninitialized in > > this

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-13 Thread Boris Brezillon
Hi Geert, On Thu, 13 Oct 2016 16:05:36 +0200 Geert Uytterhoeven wrote: > drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’: > drivers/mtd/ubi/eba.c:744: warning: ‘vid_hdr’ is used uninitialized in > this function > > The pointer vid_hdr is indeed not

Re: [PATCH] UBI: Fix crash in try_recover_peb()

2016-10-13 Thread Boris Brezillon
Hi Geert, On Thu, 13 Oct 2016 16:05:36 +0200 Geert Uytterhoeven wrote: > drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’: > drivers/mtd/ubi/eba.c:744: warning: ‘vid_hdr’ is used uninitialized in > this function > > The pointer vid_hdr is indeed not initialized, leading to a crash

[PATCH] UBI: Fix crash in try_recover_peb()

2016-10-13 Thread Geert Uytterhoeven
drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’: drivers/mtd/ubi/eba.c:744: warning: ‘vid_hdr’ is used uninitialized in this function The pointer vid_hdr is indeed not initialized, leading to a crash when it is dereferenced. Fix this by obtaining the pointer from the VID buffer,

[PATCH] UBI: Fix crash in try_recover_peb()

2016-10-13 Thread Geert Uytterhoeven
drivers/mtd/ubi/eba.c: In function ‘try_recover_peb’: drivers/mtd/ubi/eba.c:744: warning: ‘vid_hdr’ is used uninitialized in this function The pointer vid_hdr is indeed not initialized, leading to a crash when it is dereferenced. Fix this by obtaining the pointer from the VID buffer,