On Sun, May 20, 2007 at 04:20:10PM +0400, Cyrill Gorcunov wrote:
> I almost have completed UDF style conversation (the only thing to do
> is to check all I've changed). And I've been striked down by the simple
> question: the conversion I've done is over 2.6.22-rc1 but meantime in -mm
> tree two
On Sun 20-05-07 16:20:10, Cyrill Gorcunov wrote:
> [Christoph Hellwig - Wed, May 16, 2007 at 06:56:00PM +0100]
> | On Wed, May 16, 2007 at 09:52:57PM +0400, Cyrill Gorcunov wrote:
> | > I've that documants even printed ;) Actually they are _very-very_ big
> | > indeed. I don't know may be just try
On Sun 20-05-07 16:20:10, Cyrill Gorcunov wrote:
[Christoph Hellwig - Wed, May 16, 2007 at 06:56:00PM +0100]
| On Wed, May 16, 2007 at 09:52:57PM +0400, Cyrill Gorcunov wrote:
| I've that documants even printed ;) Actually they are _very-very_ big
| indeed. I don't know may be just try to
On Sun, May 20, 2007 at 04:20:10PM +0400, Cyrill Gorcunov wrote:
I almost have completed UDF style conversation (the only thing to do
is to check all I've changed). And I've been striked down by the simple
question: the conversion I've done is over 2.6.22-rc1 but meantime in -mm
tree two my
[Christoph Hellwig - Wed, May 16, 2007 at 06:56:00PM +0100]
| On Wed, May 16, 2007 at 09:52:57PM +0400, Cyrill Gorcunov wrote:
| > I've that documants even printed ;) Actually they are _very-very_ big
| > indeed. I don't know may be just try to bring this code into Linux
| > codying style?
|
|
On Wed, May 16, 2007 at 09:52:57PM +0400, Cyrill Gorcunov wrote:
> I've that documants even printed ;) Actually they are _very-very_ big
> indeed. I don't know may be just try to bring this code into Linux
> codying style?
That's probably a good step. And while converting things to a proper
[Jan Kara - Wed, May 16, 2007 at 07:38:52PM +0200]
| > [Christoph Hellwig - Sun, May 13, 2007 at 10:01:26PM +0100]
| > | On Fri, May 11, 2007 at 03:09:20PM +0400, Cyrill Gorcunov wrote:
| > | > | > | And please get rid of the UDF_I_* macro for everything you touch,
just
| > | > | > | put a
| > |
> [Christoph Hellwig - Sun, May 13, 2007 at 10:01:26PM +0100]
> | On Fri, May 11, 2007 at 03:09:20PM +0400, Cyrill Gorcunov wrote:
> | > | > | And please get rid of the UDF_I_* macro for everything you touch,
> just
> | > | > | put a
> | > | > |
> | > | > | struct udf_inode_info *uip =
[Christoph Hellwig - Sun, May 13, 2007 at 10:01:26PM +0100]
| On Fri, May 11, 2007 at 03:09:20PM +0400, Cyrill Gorcunov wrote:
| > | > | And please get rid of the UDF_I_* macro for everything you touch, just
| > | > | put a
| > | > |
| > | > | struct udf_inode_info *uip = UDF_I(inode);
| >
[Christoph Hellwig - Sun, May 13, 2007 at 10:01:26PM +0100]
| On Fri, May 11, 2007 at 03:09:20PM +0400, Cyrill Gorcunov wrote:
| | | And please get rid of the UDF_I_* macro for everything you touch, just
| | | put a
| | |
| | | struct udf_inode_info *uip = UDF_I(inode);
| | |
|
[Christoph Hellwig - Sun, May 13, 2007 at 10:01:26PM +0100]
| On Fri, May 11, 2007 at 03:09:20PM +0400, Cyrill Gorcunov wrote:
| | | And please get rid of the UDF_I_* macro for everything you touch,
just
| | | put a
| | |
| | | struct udf_inode_info *uip = UDF_I(inode);
| |
[Jan Kara - Wed, May 16, 2007 at 07:38:52PM +0200]
| [Christoph Hellwig - Sun, May 13, 2007 at 10:01:26PM +0100]
| | On Fri, May 11, 2007 at 03:09:20PM +0400, Cyrill Gorcunov wrote:
| | | | And please get rid of the UDF_I_* macro for everything you touch,
just
| | | | put a
| | | |
|
On Wed, May 16, 2007 at 09:52:57PM +0400, Cyrill Gorcunov wrote:
I've that documants even printed ;) Actually they are _very-very_ big
indeed. I don't know may be just try to bring this code into Linux
codying style?
That's probably a good step. And while converting things to a proper
style
On Fri, May 11, 2007 at 03:09:20PM +0400, Cyrill Gorcunov wrote:
> | > | And please get rid of the UDF_I_* macro for everything you touch, just
> | > | put a
> | > |
> | > | struct udf_inode_info *uip = UDF_I(inode);
> | > |
> | > | at the beginning of the function and use the fields
On Fri, May 11, 2007 at 03:09:20PM +0400, Cyrill Gorcunov wrote:
| | And please get rid of the UDF_I_* macro for everything you touch, just
| | put a
| |
| | struct udf_inode_info *uip = UDF_I(inode);
| |
| | at the beginning of the function and use the fields directly.
| |
[Pekka Enberg - Sat, May 12, 2007 at 01:15:14PM +0300]
| Hi Cyrill
|
| On 5/12/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
| >you know I've got a question (may be it's stupid) - what a
| >sense to discard UDF_I_* macroses? I mean as I see they
| >don't slow down execution of the code...
|
|
Hi Cyrill
On 5/12/07, Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
you know I've got a question (may be it's stupid) - what a
sense to discard UDF_I_* macroses? I mean as I see they
don't slow down execution of the code...
They make the code harder to read and maintain.
-
To unsubscribe from
Christoph,
you know I've got a question (may be it's stupid) - what a
sense to discard UDF_I_* macroses? I mean as I see they
don't slow down execution of the code...
Cyrill
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to
Christoph,
you know I've got a question (may be it's stupid) - what a
sense to discard UDF_I_* macroses? I mean as I see they
don't slow down execution of the code...
Cyrill
-
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to
Hi Cyrill
On 5/12/07, Cyrill Gorcunov [EMAIL PROTECTED] wrote:
you know I've got a question (may be it's stupid) - what a
sense to discard UDF_I_* macroses? I mean as I see they
don't slow down execution of the code...
They make the code harder to read and maintain.
-
To unsubscribe from this
[Pekka Enberg - Sat, May 12, 2007 at 01:15:14PM +0300]
| Hi Cyrill
|
| On 5/12/07, Cyrill Gorcunov [EMAIL PROTECTED] wrote:
| you know I've got a question (may be it's stupid) - what a
| sense to discard UDF_I_* macroses? I mean as I see they
| don't slow down execution of the code...
|
| They
[Christoph Hellwig - Fri, May 11, 2007 at 11:39:56AM +0100]
| On Fri, May 11, 2007 at 01:01:27PM +0400, Cyrill Gorcunov wrote:
| > [Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
| >
| > ...
| >
| > | And please get rid of the UDF_I_* macro for everything you touch, just
| > | put a
On Fri, May 11, 2007 at 01:01:27PM +0400, Cyrill Gorcunov wrote:
> [Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
>
> ...
>
> | And please get rid of the UDF_I_* macro for everything you touch, just
> | put a
> |
> | struct udf_inode_info *uip = UDF_I(inode);
> |
> | at the
[Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
...
| And please get rid of the UDF_I_* macro for everything you touch, just
| put a
|
| struct udf_inode_info *uip = UDF_I(inode);
|
| at the beginning of the function and use the fields directly.
|
Actually to properly
[Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
[..snip..]
| And please get rid of the UDF_I_* macro for everything you touch, just
| put a
|
| struct udf_inode_info *uip = UDF_I(inode);
|
| at the beginning of the function and use the fields directly.
|
Christoph, I think
[Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
| On Thu, May 10, 2007 at 03:46:40PM -0700, Andrew Morton wrote:
| > On Thu, 10 May 2007 18:00:00 +0400
| > Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
| >
| > > This patch adds cheking for granted memory while
| > > filling up inode data
On Thu, May 10, 2007 at 03:46:40PM -0700, Andrew Morton wrote:
> On Thu, 10 May 2007 18:00:00 +0400
> Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
>
> > This patch adds cheking for granted memory while
> > filling up inode data to prevent possible NULL
> > pointer usage. If there is not enough
This patch adds checking for granted memory while filling up inode data
to prevent possible NULL pointer usage. If there is not enough memory
to fill inode data we just mark it as "bad". Also some whitespace cleanup.
Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]>
---
Andrew, don't be
This patch adds checking for granted memory while filling up inode data
to prevent possible NULL pointer usage. If there is not enough memory
to fill inode data we just mark it as bad. Also some whitespace cleanup.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
Andrew, don't be surprised
On Thu, May 10, 2007 at 03:46:40PM -0700, Andrew Morton wrote:
On Thu, 10 May 2007 18:00:00 +0400
Cyrill Gorcunov [EMAIL PROTECTED] wrote:
This patch adds cheking for granted memory while
filling up inode data to prevent possible NULL
pointer usage. If there is not enough memory to
[Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
| On Thu, May 10, 2007 at 03:46:40PM -0700, Andrew Morton wrote:
| On Thu, 10 May 2007 18:00:00 +0400
| Cyrill Gorcunov [EMAIL PROTECTED] wrote:
|
| This patch adds cheking for granted memory while
| filling up inode data to
[Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
[..snip..]
| And please get rid of the UDF_I_* macro for everything you touch, just
| put a
|
| struct udf_inode_info *uip = UDF_I(inode);
|
| at the beginning of the function and use the fields directly.
|
Christoph, I think
[Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
...
| And please get rid of the UDF_I_* macro for everything you touch, just
| put a
|
| struct udf_inode_info *uip = UDF_I(inode);
|
| at the beginning of the function and use the fields directly.
|
Actually to properly
On Fri, May 11, 2007 at 01:01:27PM +0400, Cyrill Gorcunov wrote:
[Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
...
| And please get rid of the UDF_I_* macro for everything you touch, just
| put a
|
| struct udf_inode_info *uip = UDF_I(inode);
|
| at the beginning of
[Christoph Hellwig - Fri, May 11, 2007 at 11:39:56AM +0100]
| On Fri, May 11, 2007 at 01:01:27PM +0400, Cyrill Gorcunov wrote:
| [Christoph Hellwig - Fri, May 11, 2007 at 08:29:39AM +0100]
|
| ...
|
| | And please get rid of the UDF_I_* macro for everything you touch, just
| | put a
| |
[Andrew Morton - Thu, May 10, 2007 at 03:46:40PM -0700]
[...snip...]
| But please let's not add three copies of identical code. Do something like:
[...snip...]
Thanks for comments, Andrew. Let me rewrite the patch...
Cyrill
-
To unsubscribe from this list: send the line
On Thu, 10 May 2007 18:00:00 +0400
Cyrill Gorcunov <[EMAIL PROTECTED]> wrote:
> This patch adds cheking for granted memory while
> filling up inode data to prevent possible NULL
> pointer usage. If there is not enough memory to
> fill inode data we just mark it as "bad".
>
> Signed-off-by:
This patch adds cheking for granted memory while
filling up inode data to prevent possible NULL
pointer usage. If there is not enough memory to
fill inode data we just mark it as "bad".
Signed-off-by: Cyrill Gorcunov <[EMAIL PROTECTED]>
---
Please check the patch, maybe just marking inode as
This patch adds cheking for granted memory while
filling up inode data to prevent possible NULL
pointer usage. If there is not enough memory to
fill inode data we just mark it as bad.
Signed-off-by: Cyrill Gorcunov [EMAIL PROTECTED]
---
Please check the patch, maybe just marking inode as
bad is
On Thu, 10 May 2007 18:00:00 +0400
Cyrill Gorcunov [EMAIL PROTECTED] wrote:
This patch adds cheking for granted memory while
filling up inode data to prevent possible NULL
pointer usage. If there is not enough memory to
fill inode data we just mark it as bad.
Signed-off-by: Cyrill Gorcunov
[Andrew Morton - Thu, May 10, 2007 at 03:46:40PM -0700]
[...snip...]
| But please let's not add three copies of identical code. Do something like:
[...snip...]
Thanks for comments, Andrew. Let me rewrite the patch...
Cyrill
-
To unsubscribe from this list: send the line
41 matches
Mail list logo
