Re: [PATCH] UPDATED: hfs: handle more on-disk corruptions without oopsing

2007-12-23 Thread Eric Sandeen
Roman Zippel wrote: > Hi, > > On Thursday 20 December 2007, Eric Sandeen wrote: > >> Index: linux-2.6.24-rc3/fs/hfs/brec.c >> === >> --- linux-2.6.24-rc3.orig/fs/hfs/brec.c >> +++ linux-2.6.24-rc3/fs/hfs/brec.c >> @@ -44,10 +44,21

Re: [PATCH] UPDATED: hfs: handle more on-disk corruptions without oopsing

2007-12-23 Thread Roman Zippel
Hi, On Thursday 20 December 2007, Eric Sandeen wrote: > Index: linux-2.6.24-rc3/fs/hfs/brec.c > === > --- linux-2.6.24-rc3.orig/fs/hfs/brec.c > +++ linux-2.6.24-rc3/fs/hfs/brec.c > @@ -44,10 +44,21 @@ u16 hfs_brec_keylen(struct

Re: [PATCH] UPDATED: hfs: handle more on-disk corruptions without oopsing

2007-12-23 Thread Roman Zippel
Hi, On Thursday 20 December 2007, Eric Sandeen wrote: Index: linux-2.6.24-rc3/fs/hfs/brec.c === --- linux-2.6.24-rc3.orig/fs/hfs/brec.c +++ linux-2.6.24-rc3/fs/hfs/brec.c @@ -44,10 +44,21 @@ u16 hfs_brec_keylen(struct hfs_bnode

Re: [PATCH] UPDATED: hfs: handle more on-disk corruptions without oopsing

2007-12-23 Thread Eric Sandeen
Roman Zippel wrote: Hi, On Thursday 20 December 2007, Eric Sandeen wrote: Index: linux-2.6.24-rc3/fs/hfs/brec.c === --- linux-2.6.24-rc3.orig/fs/hfs/brec.c +++ linux-2.6.24-rc3/fs/hfs/brec.c @@ -44,10 +44,21 @@ u16

[PATCH] UPDATED: hfs: handle more on-disk corruptions without oopsing

2007-12-20 Thread Eric Sandeen
Andrew, I double-issued warnings in some cases. Mind replacing with this one? Thanks, -Eric hfs seems prone to bad things when it encounters on disk corruption. Many values are read from disk, and used as lengths to memcpy, as an example. This patch fixes up several of these problematic cases.

[PATCH] UPDATED: hfs: handle more on-disk corruptions without oopsing

2007-12-20 Thread Eric Sandeen
Andrew, I double-issued warnings in some cases. Mind replacing with this one? Thanks, -Eric hfs seems prone to bad things when it encounters on disk corruption. Many values are read from disk, and used as lengths to memcpy, as an example. This patch fixes up several of these problematic cases.