If the function platform_get_irq() failed, the negative value
returned will not be detected here. So fix error handling in
mv_ehci_probe(). And when get irq failed, the function
platform_get_irq() logs an error message, so remove redundant
message here.

Signed-off-by: Zhang Shengju <zhangshen...@cmss.chinamobile.com>
Signed-off-by: Tang Bin <tang...@cmss.chinamobile.com>
---
 drivers/usb/host/ehci-mv.c | 5 ++---
 1 file changed, 2 insertions(+), 3 deletions(-)

diff --git a/drivers/usb/host/ehci-mv.c b/drivers/usb/host/ehci-mv.c
index 1c079953e..b2da62bfd 100644
--- a/drivers/usb/host/ehci-mv.c
+++ b/drivers/usb/host/ehci-mv.c
@@ -166,9 +166,8 @@ static int mv_ehci_probe(struct platform_device *pdev)
        hcd->regs = ehci_mv->op_regs;
 
        hcd->irq = platform_get_irq(pdev, 0);
-       if (!hcd->irq) {
-               dev_err(&pdev->dev, "Cannot get irq.");
-               retval = -ENODEV;
+       if (hcd->irq < 0) {
+               retval = hcd->irq;
                goto err_disable_clk;
        }
 
-- 
2.20.1.windows.1



Reply via email to