Re: [PATCH] USB: serial: Clean up the return values of read_reg and write_reg

2017-11-28 Thread Gimcuan Hui
On 28 November 2017 at 08:47, Johan Hovold wrote: > On Mon, Nov 27, 2017 at 03:36:51PM +, Gimcuan Hui wrote: >> write_reg returns 0 on success, we can make it more explicit by returning >> number 0 instead of result variable. >> >> read_reg should return 0 on success since this is a more commo

Re: [PATCH] USB: serial: Clean up the return values of read_reg and write_reg

2017-11-28 Thread Johan Hovold
On Mon, Nov 27, 2017 at 03:36:51PM +, Gimcuan Hui wrote: > write_reg returns 0 on success, we can make it more explicit by returning > number 0 instead of result variable. > > read_reg should return 0 on success since this is a more common pattern. > > The user of read_reg has been clean-up a

[PATCH] USB: serial: Clean up the return values of read_reg and write_reg

2017-11-27 Thread Gimcuan Hui
write_reg returns 0 on success, we can make it more explicit by returning number 0 instead of result variable. read_reg should return 0 on success since this is a more common pattern. The user of read_reg has been clean-up and should be at the same commit. Signed-off-by: Gimcuan Hui --- driver