Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-31 Thread Johan Hovold
On Mon, Oct 30, 2017 at 11:50:02PM -0500, Gustavo A. R. Silva wrote: > Quoting Johan Hovold : > > This code is pretty hard to read as is and could really use some clean > > up... > > > > I agree. I'll send a V2 of this patch and then let's see if I can help > with some code

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-31 Thread Johan Hovold
On Mon, Oct 30, 2017 at 11:50:02PM -0500, Gustavo A. R. Silva wrote: > Quoting Johan Hovold : > > This code is pretty hard to read as is and could really use some clean > > up... > > > > I agree. I'll send a V2 of this patch and then let's see if I can help > with some code refactoring.

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-30 Thread Gustavo A. R. Silva
Hi David, Johan, Quoting Johan Hovold : On Mon, Oct 30, 2017 at 11:54:33AM +, David Laight wrote: From: Bjørn Mork > Sent: 28 October 2017 11:57 > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > >

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-30 Thread Gustavo A. R. Silva
Hi David, Johan, Quoting Johan Hovold : On Mon, Oct 30, 2017 at 11:54:33AM +, David Laight wrote: From: Bjørn Mork > Sent: 28 October 2017 11:57 > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Notice that in this

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-30 Thread Johan Hovold
On Mon, Oct 30, 2017 at 11:54:33AM +, David Laight wrote: > From: Bjørn Mork > > Sent: 28 October 2017 11:57 > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we are expecting to fall through. > > > > > > Notice that in this particular case I replaced

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-30 Thread Johan Hovold
On Mon, Oct 30, 2017 at 11:54:33AM +, David Laight wrote: > From: Bjørn Mork > > Sent: 28 October 2017 11:57 > > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > > where we are expecting to fall through. > > > > > > Notice that in this particular case I replaced

RE: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-30 Thread David Laight
From: Bjørn Mork > Sent: 28 October 2017 11:57 > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Notice that in this particular case I replaced "...drop on through" > > comments with a proper "fall through" comment on its

RE: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-30 Thread David Laight
From: Bjørn Mork > Sent: 28 October 2017 11:57 > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > > where we are expecting to fall through. > > > > Notice that in this particular case I replaced "...drop on through" > > comments with a proper "fall through" comment on its

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-28 Thread Gustavo A. R. Silva
Quoting Bjørn Mork : "Gustavo A. R. Silva" writes: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced "...drop on through" comments with a proper

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-28 Thread Gustavo A. R. Silva
Quoting Bjørn Mork : "Gustavo A. R. Silva" writes: In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced "...drop on through" comments with a proper "fall through" comment on its own line,

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-28 Thread Bjørn Mork
"Gustavo A. R. Silva" writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "...drop on through" > comments with a proper "fall through" comment on its

Re: [PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-28 Thread Bjørn Mork
"Gustavo A. R. Silva" writes: > In preparation to enabling -Wimplicit-fallthrough, mark switch cases > where we are expecting to fall through. > > Notice that in this particular case I replaced "...drop on through" > comments with a proper "fall through" comment on its own line, which > is what

[PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-27 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced "...drop on through" comments with a proper "fall through" comment on its own line, which is what GCC is expecting to find. Signed-off-by:

[PATCH] USB: serial: io_edgeport: mark expected switch fall-throughs

2017-10-27 Thread Gustavo A. R. Silva
In preparation to enabling -Wimplicit-fallthrough, mark switch cases where we are expecting to fall through. Notice that in this particular case I replaced "...drop on through" comments with a proper "fall through" comment on its own line, which is what GCC is expecting to find. Signed-off-by: