On Mon, Oct 30, 2017 at 11:50:02PM -0500, Gustavo A. R. Silva wrote:
> Quoting Johan Hovold :
> > This code is pretty hard to read as is and could really use some clean
> > up...
> >
>
> I agree. I'll send a V2 of this patch and then let's see if I can help
> with some code
On Mon, Oct 30, 2017 at 11:50:02PM -0500, Gustavo A. R. Silva wrote:
> Quoting Johan Hovold :
> > This code is pretty hard to read as is and could really use some clean
> > up...
> >
>
> I agree. I'll send a V2 of this patch and then let's see if I can help
> with some code refactoring.
Hi David, Johan,
Quoting Johan Hovold :
On Mon, Oct 30, 2017 at 11:54:33AM +, David Laight wrote:
From: Bjørn Mork
> Sent: 28 October 2017 11:57
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> >
Hi David, Johan,
Quoting Johan Hovold :
On Mon, Oct 30, 2017 at 11:54:33AM +, David Laight wrote:
From: Bjørn Mork
> Sent: 28 October 2017 11:57
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Notice that in this
On Mon, Oct 30, 2017 at 11:54:33AM +, David Laight wrote:
> From: Bjørn Mork
> > Sent: 28 October 2017 11:57
> > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > > where we are expecting to fall through.
> > >
> > > Notice that in this particular case I replaced
On Mon, Oct 30, 2017 at 11:54:33AM +, David Laight wrote:
> From: Bjørn Mork
> > Sent: 28 October 2017 11:57
> > > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > > where we are expecting to fall through.
> > >
> > > Notice that in this particular case I replaced
From: Bjørn Mork
> Sent: 28 October 2017 11:57
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Notice that in this particular case I replaced "...drop on through"
> > comments with a proper "fall through" comment on its
From: Bjørn Mork
> Sent: 28 October 2017 11:57
> > In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> > where we are expecting to fall through.
> >
> > Notice that in this particular case I replaced "...drop on through"
> > comments with a proper "fall through" comment on its
Quoting Bjørn Mork :
"Gustavo A. R. Silva" writes:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I replaced "...drop on through"
comments with a proper
Quoting Bjørn Mork :
"Gustavo A. R. Silva" writes:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I replaced "...drop on through"
comments with a proper "fall through" comment on its own line,
"Gustavo A. R. Silva" writes:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case I replaced "...drop on through"
> comments with a proper "fall through" comment on its
"Gustavo A. R. Silva" writes:
> In preparation to enabling -Wimplicit-fallthrough, mark switch cases
> where we are expecting to fall through.
>
> Notice that in this particular case I replaced "...drop on through"
> comments with a proper "fall through" comment on its own line, which
> is what
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I replaced "...drop on through"
comments with a proper "fall through" comment on its own line, which
is what GCC is expecting to find.
Signed-off-by:
In preparation to enabling -Wimplicit-fallthrough, mark switch cases
where we are expecting to fall through.
Notice that in this particular case I replaced "...drop on through"
comments with a proper "fall through" comment on its own line, which
is what GCC is expecting to find.
Signed-off-by:
14 matches
Mail list logo