Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Borislav Petkov
On Tue, Jun 19, 2018 at 11:32:56PM +0200, Borislav Petkov wrote: > config CRYPTO_DEV_SP_PSP > bool "Platform Security Processor (PSP) device" > default y > depends on CRYPTO_DEV_CCP_DD && X86_64 > > so CRYPTO_DEV_SP_PSP already depends on CRYPTO_DEV_CCP_DD! > > So why

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Borislav Petkov
On Tue, Jun 19, 2018 at 11:32:56PM +0200, Borislav Petkov wrote: > config CRYPTO_DEV_SP_PSP > bool "Platform Security Processor (PSP) device" > default y > depends on CRYPTO_DEV_CCP_DD && X86_64 > > so CRYPTO_DEV_SP_PSP already depends on CRYPTO_DEV_CCP_DD! > > So why

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Borislav Petkov
On Tue, Jun 19, 2018 at 03:46:40PM -0500, Brijesh Singh wrote: > In case if it was not clear, we don't have a standalone PSP driver. > The PSP support is provided by the CCP driver. If you look at config > changes I proposed then it says if PSP is available then we can support > SEV. But since PSP

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Borislav Petkov
On Tue, Jun 19, 2018 at 03:46:40PM -0500, Brijesh Singh wrote: > In case if it was not clear, we don't have a standalone PSP driver. > The PSP support is provided by the CCP driver. If you look at config > changes I proposed then it says if PSP is available then we can support > SEV. But since PSP

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Brijesh Singh
On 06/19/2018 02:43 PM, Borislav Petkov wrote: On Tue, Jun 19, 2018 at 02:22:53PM -0500, Brijesh Singh wrote: It would be nice to have a single depends. But the main issue is, PSP support is provided through the ccp driver (aka CRYPTO_DEV_CCP_DD). And this sentence states also your

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Brijesh Singh
On 06/19/2018 02:43 PM, Borislav Petkov wrote: On Tue, Jun 19, 2018 at 02:22:53PM -0500, Brijesh Singh wrote: It would be nice to have a single depends. But the main issue is, PSP support is provided through the ccp driver (aka CRYPTO_DEV_CCP_DD). And this sentence states also your

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Borislav Petkov
On Tue, Jun 19, 2018 at 02:22:53PM -0500, Brijesh Singh wrote: > It would be nice to have a single depends. But the main issue is, PSP > support is provided through the ccp driver (aka CRYPTO_DEV_CCP_DD). And this sentence states also your dependency: KVM_AMD_SEV <- PSP driver <- CCP driver but

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Borislav Petkov
On Tue, Jun 19, 2018 at 02:22:53PM -0500, Brijesh Singh wrote: > It would be nice to have a single depends. But the main issue is, PSP > support is provided through the ccp driver (aka CRYPTO_DEV_CCP_DD). And this sentence states also your dependency: KVM_AMD_SEV <- PSP driver <- CCP driver but

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Brijesh Singh
Hi Boris, On 06/19/2018 04:46 AM, Borislav Petkov wrote: On Thu, Jun 14, 2018 at 07:08:26AM -0500, Brijesh Singh wrote: I think depends should look like this: config KVM_AMD_SEV     def_bool y     bool "AMD Secure Encrypted Virtualization (SEV) support"     depends KVM_AMD && X86_64    

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Brijesh Singh
Hi Boris, On 06/19/2018 04:46 AM, Borislav Petkov wrote: On Thu, Jun 14, 2018 at 07:08:26AM -0500, Brijesh Singh wrote: I think depends should look like this: config KVM_AMD_SEV     def_bool y     bool "AMD Secure Encrypted Virtualization (SEV) support"     depends KVM_AMD && X86_64    

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Borislav Petkov
On Thu, Jun 14, 2018 at 07:08:26AM -0500, Brijesh Singh wrote: > I think depends should look like this: > > config KVM_AMD_SEV >     def_bool y >     bool "AMD Secure Encrypted Virtualization (SEV) support" >     depends KVM_AMD && X86_64 >     depends CRYPTO_DEV_SP_PSP && !(KVM_AMD=y &&

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-19 Thread Borislav Petkov
On Thu, Jun 14, 2018 at 07:08:26AM -0500, Brijesh Singh wrote: > I think depends should look like this: > > config KVM_AMD_SEV >     def_bool y >     bool "AMD Secure Encrypted Virtualization (SEV) support" >     depends KVM_AMD && X86_64 >     depends CRYPTO_DEV_SP_PSP && !(KVM_AMD=y &&

[PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-14 Thread Felix Niederwanger
On 14/06/18 14:08, Brijesh Singh wrote: > > > On 6/14/18 2:58 AM, Richard Weinberger wrote: >> On Wed, May 23, 2018 at 4:46 PM, Borislav Petkov wrote: >>> + Tom and Brijesh. >>> >>> On Mon, May 21, 2018 at 10:12:53AM -0500, Janakarajan Natarajan wrote: Use Kconfig imply 'option' when

[PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-14 Thread Felix Niederwanger
On 14/06/18 14:08, Brijesh Singh wrote: > > > On 6/14/18 2:58 AM, Richard Weinberger wrote: >> On Wed, May 23, 2018 at 4:46 PM, Borislav Petkov wrote: >>> + Tom and Brijesh. >>> >>> On Mon, May 21, 2018 at 10:12:53AM -0500, Janakarajan Natarajan wrote: Use Kconfig imply 'option' when

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-14 Thread Brijesh Singh
On 6/14/18 2:58 AM, Richard Weinberger wrote: > On Wed, May 23, 2018 at 4:46 PM, Borislav Petkov wrote: >> + Tom and Brijesh. >> >> On Mon, May 21, 2018 at 10:12:53AM -0500, Janakarajan Natarajan wrote: >>> Use Kconfig imply 'option' when specifying SEV CRYPTO dependencies. >>> >>> Example

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-14 Thread Brijesh Singh
On 6/14/18 2:58 AM, Richard Weinberger wrote: > On Wed, May 23, 2018 at 4:46 PM, Borislav Petkov wrote: >> + Tom and Brijesh. >> >> On Mon, May 21, 2018 at 10:12:53AM -0500, Janakarajan Natarajan wrote: >>> Use Kconfig imply 'option' when specifying SEV CRYPTO dependencies. >>> >>> Example

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-14 Thread Richard Weinberger
On Wed, May 23, 2018 at 4:46 PM, Borislav Petkov wrote: > + Tom and Brijesh. > > On Mon, May 21, 2018 at 10:12:53AM -0500, Janakarajan Natarajan wrote: >> Use Kconfig imply 'option' when specifying SEV CRYPTO dependencies. >> >> Example configuration: >> . >> . >> CONFIG_CRYPTO_DEV_CCP=y >>

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-06-14 Thread Richard Weinberger
On Wed, May 23, 2018 at 4:46 PM, Borislav Petkov wrote: > + Tom and Brijesh. > > On Mon, May 21, 2018 at 10:12:53AM -0500, Janakarajan Natarajan wrote: >> Use Kconfig imply 'option' when specifying SEV CRYPTO dependencies. >> >> Example configuration: >> . >> . >> CONFIG_CRYPTO_DEV_CCP=y >>

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-05-23 Thread Borislav Petkov
+ Tom and Brijesh. On Mon, May 21, 2018 at 10:12:53AM -0500, Janakarajan Natarajan wrote: > Use Kconfig imply 'option' when specifying SEV CRYPTO dependencies. > > Example configuration: > . > . > CONFIG_CRYPTO_DEV_CCP=y > CONFIG_CRYPTO_DEV_CCP_DD=m > CONFIG_CRYPTO_DEV_SP_CCP=y >

Re: [PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-05-23 Thread Borislav Petkov
+ Tom and Brijesh. On Mon, May 21, 2018 at 10:12:53AM -0500, Janakarajan Natarajan wrote: > Use Kconfig imply 'option' when specifying SEV CRYPTO dependencies. > > Example configuration: > . > . > CONFIG_CRYPTO_DEV_CCP=y > CONFIG_CRYPTO_DEV_CCP_DD=m > CONFIG_CRYPTO_DEV_SP_CCP=y >

[PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-05-21 Thread Janakarajan Natarajan
Use Kconfig imply 'option' when specifying SEV CRYPTO dependencies. Example configuration: . . CONFIG_CRYPTO_DEV_CCP=y CONFIG_CRYPTO_DEV_CCP_DD=m CONFIG_CRYPTO_DEV_SP_CCP=y CONFIG_CRYPTO_DEV_CCP_CRYPTO=m CONFIG_CRYPTO_DEV_SP_PSP=y . . CONFIG_KVM_AMD=y CONFIG_KVM_AMD_SEV=y . . When the

[PATCH] Use 'imply' with SEV Kconfig CRYPTO dependencies

2018-05-21 Thread Janakarajan Natarajan
Use Kconfig imply 'option' when specifying SEV CRYPTO dependencies. Example configuration: . . CONFIG_CRYPTO_DEV_CCP=y CONFIG_CRYPTO_DEV_CCP_DD=m CONFIG_CRYPTO_DEV_SP_CCP=y CONFIG_CRYPTO_DEV_CCP_CRYPTO=m CONFIG_CRYPTO_DEV_SP_PSP=y . . CONFIG_KVM_AMD=y CONFIG_KVM_AMD_SEV=y . . When the