Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-08 Thread Christoph Hellwig
On Fri, Apr 08, 2005 at 01:10:11AM -0700, Jeremy Higdon wrote: > Just as a sanity check, you meant "lsscsi" and not "lssci" in your original > reply, right? Yes. - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-08 Thread Jeremy Higdon
On Fri, Apr 08, 2005 at 08:56:43AM +0100, Christoph Hellwig wrote: > On Fri, Apr 08, 2005 at 12:23:46AM -0700, Jeremy Higdon wrote: > > Even if it's deprecated, wouldn't it be good to fix it as long as > > it's there, unless it hurts something else? Or at least fix the > > out of memory error, eve

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-08 Thread Christoph Hellwig
On Fri, Apr 08, 2005 at 12:23:46AM -0700, Jeremy Higdon wrote: > > It works for those setups that already worked with 2.4.x, aka only a few > > luns. > > Even if it's deprecated, wouldn't it be good to fix it as long as > it's there, unless it hurts something else? Or at least fix the > out of me

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-08 Thread Arjan van de Ven
On Fri, 2005-04-08 at 08:56 +0100, Christoph Hellwig wrote: > On Fri, Apr 08, 2005 at 12:23:46AM -0700, Jeremy Higdon wrote: > > > It works for those setups that already worked with 2.4.x, aka only a few > > > luns. > > > > Even if it's deprecated, wouldn't it be good to fix it as long as > > it's

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-08 Thread Jeremy Higdon
On Thu, Apr 07, 2005 at 12:24:12PM +0100, Christoph Hellwig wrote: > On Thu, Apr 07, 2005 at 01:21:23PM +0200, Hannes Reinecke wrote: > > > /proc/scsi/scsi is deprecated and even only compiled in if > > > "legacy /proc/scsi/ support" is enabled. Please move over to lssci which > > > is using sysfs

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-07 Thread Christoph Hellwig
On Thu, Apr 07, 2005 at 01:21:23PM +0200, Hannes Reinecke wrote: > > /proc/scsi/scsi is deprecated and even only compiled in if > > "legacy /proc/scsi/ support" is enabled. Please move over to lssci which > > is using sysfs ASAP. > > > Ah. And that's enough reason for it not to work properly? > D

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-07 Thread Hannes Reinecke
Christoph Hellwig wrote: > On Thu, Apr 07, 2005 at 11:46:27AM +0200, Hannes Reinecke wrote: >>Hi all, >> >>/proc/scsi/scsi currently has a very dumb implementation of the seq_file >>api which causes 'cat /proc/scsi/scsi' to return with -ENOMEM when a >>large amount of devices are connected. > > /p

Re: [PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-07 Thread Christoph Hellwig
On Thu, Apr 07, 2005 at 11:46:27AM +0200, Hannes Reinecke wrote: > Hi all, > > /proc/scsi/scsi currently has a very dumb implementation of the seq_file > api which causes 'cat /proc/scsi/scsi' to return with -ENOMEM when a > large amount of devices are connected. /proc/scsi/scsi is deprecated and

[PATCH] Use proper seq_file api for /proc/scsi/scsi

2005-04-07 Thread Hannes Reinecke
Hi all, /proc/scsi/scsi currently has a very dumb implementation of the seq_file api which causes 'cat /proc/scsi/scsi' to return with -ENOMEM when a large amount of devices are connected. This patch impelements the proper seq_file interface which prints out all devices sequentially. The use of '