Re: [PATCH] Using a pointer and kzalloc in place of a struct directly

2020-09-13 Thread Greg KH
On Sun, Sep 13, 2020 at 01:32:43AM +0530, Anant Thazhemadam wrote: > On 12/09/20 8:25 pm, Greg KH wrote: > > On Sat, Sep 12, 2020 at 05:43:38PM +0530, Anant Thazhemadam wrote: > >> On 12/09/20 5:17 pm, Greg KH wrote: > >>> Note, your "To:" line seemed corrupted, and why not cc: the bpf mailing > >>

Re: [PATCH] Using a pointer and kzalloc in place of a struct directly

2020-09-12 Thread Anant Thazhemadam
On 12/09/20 8:25 pm, Greg KH wrote: > On Sat, Sep 12, 2020 at 05:43:38PM +0530, Anant Thazhemadam wrote: >> On 12/09/20 5:17 pm, Greg KH wrote: >>> Note, your "To:" line seemed corrupted, and why not cc: the bpf mailing >>> list as well? >> Oh, I'm sorry about that. I pulled the emails of all the

Re: [PATCH] Using a pointer and kzalloc in place of a struct directly

2020-09-12 Thread Greg KH
On Sat, Sep 12, 2020 at 05:43:38PM +0530, Anant Thazhemadam wrote: > > On 12/09/20 5:17 pm, Greg KH wrote: > > Note, your "To:" line seemed corrupted, and why not cc: the bpf mailing > > list as well? > Oh, I'm sorry about that. I pulled the emails of all the people to whom > this mail was sent of

Re: [PATCH] Using a pointer and kzalloc in place of a struct directly

2020-09-12 Thread Anant Thazhemadam
On 12/09/20 5:17 pm, Greg KH wrote: > Note, your "To:" line seemed corrupted, and why not cc: the bpf mailing > list as well? Oh, I'm sorry about that. I pulled the emails of all the people to whom this mail was sent off from the header in lkml mail, and just cc-ed everyone. > You leaked memory

Re: [PATCH] Using a pointer and kzalloc in place of a struct directly

2020-09-12 Thread Greg KH
On Sat, Sep 12, 2020 at 05:08:04PM +0530, Anant Thazhemadam wrote: > Updated the usage of a struct variable directly, in bpf_link_get_info_by_fd > to using a pointer of the same type instead, which points to a memory > location allocated using kzalloc. > > Signed-off-by: Anant Thazhemadam Note,

[PATCH] Using a pointer and kzalloc in place of a struct directly

2020-09-12 Thread Anant Thazhemadam
Updated the usage of a struct variable directly, in bpf_link_get_info_by_fd to using a pointer of the same type instead, which points to a memory location allocated using kzalloc. Signed-off-by: Anant Thazhemadam --- I saw this bug (https://syzkaller.appspot.com/bug?extid=976d5ecfab0c7eb43ac3),