Re: [PATCH] VERIFY_OCTAL_PERMISSIONS needs

2014-12-05 Thread Andrew Morton
On 5 Dec 2014 19:07:59 -0500 "George Spelvin" wrote: > It is possible to include and try to use > VERIFY_OCTAL_PERMISSIONS, then puke because BUILD_BUG_ON_ZERO > isn't defined. > > I hit this via: > > #include > module_param(verbose, bool, 0); > > IMHO, except in documented special cases,

Re: [PATCH] VERIFY_OCTAL_PERMISSIONS needs

2014-12-05 Thread Randy Dunlap
On 12/05/14 16:07, George Spelvin wrote: > It is possible to include and try to use > VERIFY_OCTAL_PERMISSIONS, then puke because BUILD_BUG_ON_ZERO > isn't defined. > > I hit this via: > > #include > module_param(verbose, bool, 0); > > IMHO, except in documented special cases, header files

[PATCH] VERIFY_OCTAL_PERMISSIONS needs

2014-12-05 Thread George Spelvin
It is possible to include and try to use VERIFY_OCTAL_PERMISSIONS, then puke because BUILD_BUG_ON_ZERO isn't defined. I hit this via: #include module_param(verbose, bool, 0); IMHO, except in documented special cases, header files should #include their own macros' dependencies. Signed-off-by:

[PATCH] VERIFY_OCTAL_PERMISSIONS needs linux/bug.h

2014-12-05 Thread George Spelvin
It is possible to include linux/kernel.h and try to use VERIFY_OCTAL_PERMISSIONS, then puke because BUILD_BUG_ON_ZERO isn't defined. I hit this via: #include linux/moduleparam.h module_param(verbose, bool, 0); IMHO, except in documented special cases, header files should #include their own

Re: [PATCH] VERIFY_OCTAL_PERMISSIONS needs linux/bug.h

2014-12-05 Thread Randy Dunlap
On 12/05/14 16:07, George Spelvin wrote: It is possible to include linux/kernel.h and try to use VERIFY_OCTAL_PERMISSIONS, then puke because BUILD_BUG_ON_ZERO isn't defined. I hit this via: #include linux/moduleparam.h module_param(verbose, bool, 0); IMHO, except in documented special

Re: [PATCH] VERIFY_OCTAL_PERMISSIONS needs linux/bug.h

2014-12-05 Thread Andrew Morton
On 5 Dec 2014 19:07:59 -0500 George Spelvin li...@horizon.com wrote: It is possible to include linux/kernel.h and try to use VERIFY_OCTAL_PERMISSIONS, then puke because BUILD_BUG_ON_ZERO isn't defined. I hit this via: #include linux/moduleparam.h module_param(verbose, bool, 0); IMHO,