Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread Paul Bolle
On Sun, 2014-05-25 at 11:42 +0400, James Bottomley wrote: > On Sat, 2014-05-24 at 15:16 +0200, Paul Bolle wrote: > > On Sat, 2014-05-24 at 16:13 +0400, James Bottomley wrote: > > > Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. > > > Particularly we try not to touch them

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread Russell King - ARM Linux
On Wed, May 28, 2014 at 06:26:44PM +0400, James Bottomley wrote: > On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: > > Looks good, > > > > Reviewed-by: Christoph Hellwig > > > > And I have to disagree with James here, removing code that isn't even > > compiled always is an

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread James Bottomley
On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: > On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote: > > The acornscsi driver was added in v2.1.88. It has always #undef-ed > > CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be > > sure, it has also always

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread Christoph Hellwig
On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote: > The acornscsi driver was added in v2.1.88. It has always #undef-ed > CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be > sure, it has also always triggered a preprocessor error if > CONFIG_SCSI_ACORNSCSI_LINK was

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread Christoph Hellwig
On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote: The acornscsi driver was added in v2.1.88. It has always #undef-ed CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be sure, it has also always triggered a preprocessor error if CONFIG_SCSI_ACORNSCSI_LINK was still

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread James Bottomley
On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: On Sat, May 24, 2014 at 12:13:53PM +0200, Paul Bolle wrote: The acornscsi driver was added in v2.1.88. It has always #undef-ed CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be sure, it has also always

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread Russell King - ARM Linux
On Wed, May 28, 2014 at 06:26:44PM +0400, James Bottomley wrote: On Wed, 2014-05-28 at 03:41 -0700, Christoph Hellwig wrote: Looks good, Reviewed-by: Christoph Hellwig h...@lst.de And I have to disagree with James here, removing code that isn't even compiled always is an

Re: [PATCH] acornscsi: remove linked command support

2014-05-28 Thread Paul Bolle
On Sun, 2014-05-25 at 11:42 +0400, James Bottomley wrote: On Sat, 2014-05-24 at 15:16 +0200, Paul Bolle wrote: On Sat, 2014-05-24 at 16:13 +0400, James Bottomley wrote: Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. Particularly we try not to touch them unless we

Re: [PATCH] acornscsi: remove linked command support

2014-05-25 Thread James Bottomley
On Sat, 2014-05-24 at 15:16 +0200, Paul Bolle wrote: > On Sat, 2014-05-24 at 16:13 +0400, James Bottomley wrote: > > Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. > > Particularly we try not to touch them unless we have to because there > > might be a few people still

Re: [PATCH] acornscsi: remove linked command support

2014-05-25 Thread James Bottomley
On Sat, 2014-05-24 at 15:16 +0200, Paul Bolle wrote: On Sat, 2014-05-24 at 16:13 +0400, James Bottomley wrote: Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. Particularly we try not to touch them unless we have to because there might be a few people still using them

Re: [PATCH] acornscsi: remove linked command support

2014-05-24 Thread Paul Bolle
On Sat, 2014-05-24 at 16:13 +0400, James Bottomley wrote: > Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. > Particularly we try not to touch them unless we have to because there > might be a few people still using them and the more we tamper, the > greater the risk that

Re: [PATCH] acornscsi: remove linked command support

2014-05-24 Thread James Bottomley
On Sat, 2014-05-24 at 12:35 +0200, Hannes Reinecke wrote: [...] > I'm all for it. Removing never-really-implemented feature on obsolete > hardware is always a good idea. > > Acked-by: Hannes Reinecke Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. Particularly we try

Re: [PATCH] acornscsi: remove linked command support

2014-05-24 Thread Hannes Reinecke
On 05/24/2014 12:13 PM, Paul Bolle wrote: The acornscsi driver was added in v2.1.88. It has always #undef-ed CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be sure, it has also always triggered a preprocessor error if CONFIG_SCSI_ACORNSCSI_LINK was still defined. But, as

[PATCH] acornscsi: remove linked command support

2014-05-24 Thread Paul Bolle
The acornscsi driver was added in v2.1.88. It has always #undef-ed CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be sure, it has also always triggered a preprocessor error if CONFIG_SCSI_ACORNSCSI_LINK was still defined. But, as far as I can see, it has never even been

[PATCH] acornscsi: remove linked command support

2014-05-24 Thread Paul Bolle
The acornscsi driver was added in v2.1.88. It has always #undef-ed CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be sure, it has also always triggered a preprocessor error if CONFIG_SCSI_ACORNSCSI_LINK was still defined. But, as far as I can see, it has never even been

Re: [PATCH] acornscsi: remove linked command support

2014-05-24 Thread Hannes Reinecke
On 05/24/2014 12:13 PM, Paul Bolle wrote: The acornscsi driver was added in v2.1.88. It has always #undef-ed CONFIG_SCSI_ACORNSCSI_LINK near the top of acornscsi.c. And, just to be sure, it has also always triggered a preprocessor error if CONFIG_SCSI_ACORNSCSI_LINK was still defined. But, as

Re: [PATCH] acornscsi: remove linked command support

2014-05-24 Thread James Bottomley
On Sat, 2014-05-24 at 12:35 +0200, Hannes Reinecke wrote: [...] I'm all for it. Removing never-really-implemented feature on obsolete hardware is always a good idea. Acked-by: Hannes Reinecke h...@suse.de Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. Particularly

Re: [PATCH] acornscsi: remove linked command support

2014-05-24 Thread Paul Bolle
On Sat, 2014-05-24 at 16:13 +0400, James Bottomley wrote: Wait, no, that's not a good idea. We leave obsolete drivers to bitrot. Particularly we try not to touch them unless we have to because there might be a few people still using them and the more we tamper, the greater the risk that