Re: [PATCH] acpi/nfit: unlock on error in scrub_show()

2019-10-21 Thread Dan Williams
On Sun, Oct 20, 2019 at 4:35 PM Rafael J. Wysocki wrote: > > On Fri, Oct 18, 2019 at 2:38 PM Dan Carpenter > wrote: > > > > We change the locking in this function and forgot to update this error > > path so we are accidentally still holding the "dev->lockdep_mutex". > > > > Fixes: 87a30e1f05d7 (

Re: [PATCH] acpi/nfit: unlock on error in scrub_show()

2019-10-20 Thread Rafael J. Wysocki
On Fri, Oct 18, 2019 at 2:38 PM Dan Carpenter wrote: > > We change the locking in this function and forgot to update this error > path so we are accidentally still holding the "dev->lockdep_mutex". > > Fixes: 87a30e1f05d7 ("driver-core, libnvdimm: Let device subsystems add local > lockdep coverag

Re: [PATCH] acpi/nfit: unlock on error in scrub_show()

2019-10-18 Thread Ira Weiny
On Fri, Oct 18, 2019 at 03:35:34PM +0300, Dan Carpenter wrote: > We change the locking in this function and forgot to update this error > path so we are accidentally still holding the "dev->lockdep_mutex". > > Fixes: 87a30e1f05d7 ("driver-core, libnvdimm: Let device subsystems add local > lockdep

Re: [PATCH] acpi/nfit: unlock on error in scrub_show()

2019-10-18 Thread Dan Williams
On Fri, Oct 18, 2019 at 5:37 AM Dan Carpenter wrote: > > We change the locking in this function and forgot to update this error > path so we are accidentally still holding the "dev->lockdep_mutex". > > Fixes: 87a30e1f05d7 ("driver-core, libnvdimm: Let device subsystems add local > lockdep coverag

[PATCH] acpi/nfit: unlock on error in scrub_show()

2019-10-18 Thread Dan Carpenter
We change the locking in this function and forgot to update this error path so we are accidentally still holding the "dev->lockdep_mutex". Fixes: 87a30e1f05d7 ("driver-core, libnvdimm: Let device subsystems add local lockdep coverage") Signed-off-by: Dan Carpenter --- drivers/acpi/nfit/core.c |