Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-08-03 Thread Baicar, Tyler
On 7/31/2017 11:44 AM, Baicar, Tyler wrote: On 7/31/2017 11:00 AM, Luck, Tony wrote: On Mon, Jul 31, 2017 at 10:15:27AM -0600, Baicar, Tyler wrote: I think the better thing to do in this case is still send the ack. If ghes_read_estatus() fails, then either we are unable to read the estatus or

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-08-03 Thread Baicar, Tyler
On 7/31/2017 11:44 AM, Baicar, Tyler wrote: On 7/31/2017 11:00 AM, Luck, Tony wrote: On Mon, Jul 31, 2017 at 10:15:27AM -0600, Baicar, Tyler wrote: I think the better thing to do in this case is still send the ack. If ghes_read_estatus() fails, then either we are unable to read the estatus or

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-31 Thread Baicar, Tyler
On 7/31/2017 11:11 AM, James Morse wrote: Hi Tyler, On 31/07/17 17:15, Baicar, Tyler wrote: On 7/29/2017 12:53 AM, Borislav Petkov wrote: On Fri, Jul 28, 2017 at 04:25:03PM -0600, Tyler Baicar wrote: Currently we acknowledge errors before clearing the error status. This could cause a new

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-31 Thread Baicar, Tyler
On 7/31/2017 11:11 AM, James Morse wrote: Hi Tyler, On 31/07/17 17:15, Baicar, Tyler wrote: On 7/29/2017 12:53 AM, Borislav Petkov wrote: On Fri, Jul 28, 2017 at 04:25:03PM -0600, Tyler Baicar wrote: Currently we acknowledge errors before clearing the error status. This could cause a new

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-31 Thread Baicar, Tyler
On 7/31/2017 11:00 AM, Luck, Tony wrote: On Mon, Jul 31, 2017 at 10:15:27AM -0600, Baicar, Tyler wrote: I think the better thing to do in this case is still send the ack. If ghes_read_estatus() fails, then either we are unable to read the estatus or the estatus is empty/invalid. Right now we

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-31 Thread Baicar, Tyler
On 7/31/2017 11:00 AM, Luck, Tony wrote: On Mon, Jul 31, 2017 at 10:15:27AM -0600, Baicar, Tyler wrote: I think the better thing to do in this case is still send the ack. If ghes_read_estatus() fails, then either we are unable to read the estatus or the estatus is empty/invalid. Right now we

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-31 Thread James Morse
Hi Tyler, On 31/07/17 17:15, Baicar, Tyler wrote: > On 7/29/2017 12:53 AM, Borislav Petkov wrote: >> On Fri, Jul 28, 2017 at 04:25:03PM -0600, Tyler Baicar wrote: >>> Currently we acknowledge errors before clearing the error status. >>> This could cause a new error to be populated by firmware

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-31 Thread James Morse
Hi Tyler, On 31/07/17 17:15, Baicar, Tyler wrote: > On 7/29/2017 12:53 AM, Borislav Petkov wrote: >> On Fri, Jul 28, 2017 at 04:25:03PM -0600, Tyler Baicar wrote: >>> Currently we acknowledge errors before clearing the error status. >>> This could cause a new error to be populated by firmware

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-31 Thread Luck, Tony
On Mon, Jul 31, 2017 at 10:15:27AM -0600, Baicar, Tyler wrote: > I think the better thing to do in this case is still send the ack. If > ghes_read_estatus() fails, then > either we are unable to read the estatus or the estatus is empty/invalid. Right now we silently handle that failure of

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-31 Thread Luck, Tony
On Mon, Jul 31, 2017 at 10:15:27AM -0600, Baicar, Tyler wrote: > I think the better thing to do in this case is still send the ack. If > ghes_read_estatus() fails, then > either we are unable to read the estatus or the estatus is empty/invalid. Right now we silently handle that failure of

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-31 Thread Baicar, Tyler
On 7/29/2017 12:53 AM, Borislav Petkov wrote: On Fri, Jul 28, 2017 at 04:25:03PM -0600, Tyler Baicar wrote: Currently we acknowledge errors before clearing the error status. This could cause a new error to be populated by firmware in-between the error acknowledgment and the error status

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-31 Thread Baicar, Tyler
On 7/29/2017 12:53 AM, Borislav Petkov wrote: On Fri, Jul 28, 2017 at 04:25:03PM -0600, Tyler Baicar wrote: Currently we acknowledge errors before clearing the error status. This could cause a new error to be populated by firmware in-between the error acknowledgment and the error status

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-29 Thread Borislav Petkov
On Fri, Jul 28, 2017 at 04:25:03PM -0600, Tyler Baicar wrote: > Currently we acknowledge errors before clearing the error status. > This could cause a new error to be populated by firmware in-between > the error acknowledgment and the error status clearing which would > cause the second error's

Re: [PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-29 Thread Borislav Petkov
On Fri, Jul 28, 2017 at 04:25:03PM -0600, Tyler Baicar wrote: > Currently we acknowledge errors before clearing the error status. > This could cause a new error to be populated by firmware in-between > the error acknowledgment and the error status clearing which would > cause the second error's

[PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-28 Thread Tyler Baicar
Currently we acknowledge errors before clearing the error status. This could cause a new error to be populated by firmware in-between the error acknowledgment and the error status clearing which would cause the second error's status to be cleared without being handled. So, clear the error status

[PATCH] acpi: apei: clear error status before acknowledging the error

2017-07-28 Thread Tyler Baicar
Currently we acknowledge errors before clearing the error status. This could cause a new error to be populated by firmware in-between the error acknowledgment and the error status clearing which would cause the second error's status to be cleared without being handled. So, clear the error status