Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-16 Thread Jason Wang
On 08/15/2012 11:10 PM, Jamal Hadi Salim wrote: On Wed, 2012-08-15 at 21:42 +0800, Jason Wang wrote: I met it actually through the following steps: - start a kvm guest with tap and make it to be an interface of the bridge - mirror the ingress traffic of the bridge to the tap - terminate the

Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-16 Thread Jason Wang
On 08/15/2012 11:10 PM, Jamal Hadi Salim wrote: On Wed, 2012-08-15 at 21:42 +0800, Jason Wang wrote: I met it actually through the following steps: - start a kvm guest with tap and make it to be an interface of the bridge - mirror the ingress traffic of the bridge to the tap - terminate the

Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jamal Hadi Salim
On Wed, 2012-08-15 at 21:42 +0800, Jason Wang wrote: > > I met it actually through the following steps: > > - start a kvm guest with tap and make it to be an interface of the bridge > - mirror the ingress traffic of the bridge to the tap > - terminate the qemu process, the tap device is then

Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jason Wang
On 08/15/2012 08:35 PM, Jamal Hadi Salim wrote: On Wed, 2012-08-15 at 17:37 +0800, Jason Wang wrote: We drop packet unconditionally when we fail to mirror it. This is not intended in some cases. Hi Jason, Did you actually notice the behavior you described or were you going by the XXX comment I

Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jamal Hadi Salim
On Wed, 2012-08-15 at 17:37 +0800, Jason Wang wrote: > We drop packet unconditionally when we fail to mirror it. This is not intended > in some cases. Hi Jason, Did you actually notice the behavior you described or were you going by the XXX comment I had in the code? cheers, jamal -- To

[PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jason Wang
We drop packet unconditionally when we fail to mirror it. This is not intended in some cases. Consdier for kvm guest, we may mirror the traffic of the bridge to a tap device used by a VM. When kernel fails to mirror the packet in conditions such as when qemu crashes or stop polling the tap, it's

[PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jason Wang
We drop packet unconditionally when we fail to mirror it. This is not intended in some cases. Consdier for kvm guest, we may mirror the traffic of the bridge to a tap device used by a VM. When kernel fails to mirror the packet in conditions such as when qemu crashes or stop polling the tap, it's

Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jamal Hadi Salim
On Wed, 2012-08-15 at 17:37 +0800, Jason Wang wrote: We drop packet unconditionally when we fail to mirror it. This is not intended in some cases. Hi Jason, Did you actually notice the behavior you described or were you going by the XXX comment I had in the code? cheers, jamal -- To

Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jason Wang
On 08/15/2012 08:35 PM, Jamal Hadi Salim wrote: On Wed, 2012-08-15 at 17:37 +0800, Jason Wang wrote: We drop packet unconditionally when we fail to mirror it. This is not intended in some cases. Hi Jason, Did you actually notice the behavior you described or were you going by the XXX comment I

Re: [PATCH] act_mirred: do not drop packets when fails to mirror it

2012-08-15 Thread Jamal Hadi Salim
On Wed, 2012-08-15 at 21:42 +0800, Jason Wang wrote: I met it actually through the following steps: - start a kvm guest with tap and make it to be an interface of the bridge - mirror the ingress traffic of the bridge to the tap - terminate the qemu process, the tap device is then removed