Re: [lm-sensors] [PATCH] adt7470: Support per-sensor alarm files

2008-01-27 Thread Mark M. Hoffman
Hi Darrick: * Darrick J. Wong <[EMAIL PROTECTED]> [2007-12-19 14:11:25 -0800]: > On Wed, Dec 19, 2007 at 03:40:12PM +0100, Jean Delvare wrote: > > In general we keep the all-in-one alarms file for compatibility, but > > given that this driver is fairly new and libsensors never had specific > >

Re: [lm-sensors] [PATCH] adt7470: Support per-sensor alarm files

2008-01-27 Thread Mark M. Hoffman
Hi Darrick: * Darrick J. Wong [EMAIL PROTECTED] [2007-12-19 14:11:25 -0800]: On Wed, Dec 19, 2007 at 03:40:12PM +0100, Jean Delvare wrote: In general we keep the all-in-one alarms file for compatibility, but given that this driver is fairly new and libsensors never had specific support for

Re: [PATCH] adt7470: Support per-sensor alarm files

2007-12-22 Thread Jean Delvare
Hi Darrick, Le 20/12/2007, Darrick J. Wong écrit: >On Thu, Dec 20, 2007 at 10:58:08AM +0100, Jean Delvare wrote: >> BTW, did you try your driver with lm-sensors 3.0.0? > >Yes I did, and it looked ok to me. Did you find something wrong? No, I just wanted to make sure that you had tested it.

Re: [PATCH] adt7470: Support per-sensor alarm files

2007-12-22 Thread Jean Delvare
Hi Darrick, Le 20/12/2007, Darrick J. Wong écrit: On Thu, Dec 20, 2007 at 10:58:08AM +0100, Jean Delvare wrote: BTW, did you try your driver with lm-sensors 3.0.0? Yes I did, and it looked ok to me. Did you find something wrong? No, I just wanted to make sure that you had tested it. Now

Re: [PATCH] adt7470: Support per-sensor alarm files

2007-12-20 Thread Darrick J. Wong
On Thu, Dec 20, 2007 at 10:58:08AM +0100, Jean Delvare wrote: > BTW, did you try your driver with lm-sensors 3.0.0? Yes I did, and it looked ok to me. Did you find something wrong? --D -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL

Re: [PATCH] adt7470: Support per-sensor alarm files

2007-12-20 Thread Jean Delvare
Hi Darrick, On Wed, 19 Dec 2007 14:11:25 -0800, Darrick J. Wong wrote: > On Wed, Dec 19, 2007 at 03:40:12PM +0100, Jean Delvare wrote: > > In general we keep the all-in-one alarms file for compatibility, but > > given that this driver is fairly new and libsensors never had specific > > support

Re: [PATCH] adt7470: Support per-sensor alarm files

2007-12-20 Thread Jean Delvare
Hi Darrick, On Wed, 19 Dec 2007 14:11:25 -0800, Darrick J. Wong wrote: On Wed, Dec 19, 2007 at 03:40:12PM +0100, Jean Delvare wrote: In general we keep the all-in-one alarms file for compatibility, but given that this driver is fairly new and libsensors never had specific support for it

Re: [PATCH] adt7470: Support per-sensor alarm files

2007-12-20 Thread Darrick J. Wong
On Thu, Dec 20, 2007 at 10:58:08AM +0100, Jean Delvare wrote: BTW, did you try your driver with lm-sensors 3.0.0? Yes I did, and it looked ok to me. Did you find something wrong? --D -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to [EMAIL

Re: [PATCH] adt7470: Support per-sensor alarm files

2007-12-19 Thread Darrick J. Wong
On Wed, Dec 19, 2007 at 03:40:12PM +0100, Jean Delvare wrote: > In general we keep the all-in-one alarms file for compatibility, but > given that this driver is fairly new and libsensors never had specific > support for it anyway, it's probably OK to drop it this time. Thanks for the code review.

Re: [PATCH] adt7470: Support per-sensor alarm files

2007-12-19 Thread Jean Delvare
Hi Darrick, On Tue, 18 Dec 2007 20:01:23 -0800, Darrick J. Wong wrote: > Remove the old alarms sysfs hack and replace it with per-sensor alarm files. > Also don't read the second alarm register if it's not needed. Thanks for doing this, I appreciate it. There are so many drivers left to

Re: [PATCH] adt7470: Support per-sensor alarm files

2007-12-19 Thread Jean Delvare
Hi Darrick, On Tue, 18 Dec 2007 20:01:23 -0800, Darrick J. Wong wrote: Remove the old alarms sysfs hack and replace it with per-sensor alarm files. Also don't read the second alarm register if it's not needed. Thanks for doing this, I appreciate it. There are so many drivers left to convert...

Re: [PATCH] adt7470: Support per-sensor alarm files

2007-12-19 Thread Darrick J. Wong
On Wed, Dec 19, 2007 at 03:40:12PM +0100, Jean Delvare wrote: In general we keep the all-in-one alarms file for compatibility, but given that this driver is fairly new and libsensors never had specific support for it anyway, it's probably OK to drop it this time. Thanks for the code review.

[PATCH] adt7470: Support per-sensor alarm files

2007-12-18 Thread Darrick J. Wong
Remove the old alarms sysfs hack and replace it with per-sensor alarm files. Also don't read the second alarm register if it's not needed. Signed-off-by: Darrick J. Wong <[EMAIL PROTECTED]> --- drivers/hwmon/adt7470.c | 97 ++- 1 files changed, 86

[PATCH] adt7470: Support per-sensor alarm files

2007-12-18 Thread Darrick J. Wong
Remove the old alarms sysfs hack and replace it with per-sensor alarm files. Also don't read the second alarm register if it's not needed. Signed-off-by: Darrick J. Wong [EMAIL PROTECTED] --- drivers/hwmon/adt7470.c | 97 ++- 1 files changed, 86