Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-09 Thread Borislav Petkov
On Mon, Dec 09, 2013 at 04:41:18PM -0700, Bjorn Helgaas wrote: > I think it's worthwhile to keep all three patches together, and I'd > be happy to merge them via PCI. It looks like Joe had some good > questions, so once you resolve them, I can merge them, or ack them and > you can take them. I

Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-09 Thread Bjorn Helgaas
[+cc Joe] On Sun, Dec 8, 2013 at 8:09 AM, Borislav Petkov wrote: > On Sun, Dec 08, 2013 at 03:43:12PM +0100, Borislav Petkov wrote: >> On Sun, Dec 08, 2013 at 12:17:53PM +0800, Rui Wang wrote: >> > There's inconsistency between dmesg and the trace event output. >> > When dmesg says

Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-09 Thread Bjorn Helgaas
[+cc Joe] On Sun, Dec 8, 2013 at 8:09 AM, Borislav Petkov b...@alien8.de wrote: On Sun, Dec 08, 2013 at 03:43:12PM +0100, Borislav Petkov wrote: On Sun, Dec 08, 2013 at 12:17:53PM +0800, Rui Wang wrote: There's inconsistency between dmesg and the trace event output. When dmesg says

Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-09 Thread Borislav Petkov
On Mon, Dec 09, 2013 at 04:41:18PM -0700, Bjorn Helgaas wrote: I think it's worthwhile to keep all three patches together, and I'd be happy to merge them via PCI. It looks like Joe had some good questions, so once you resolve them, I can merge them, or ack them and you can take them. I think

Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-08 Thread Borislav Petkov
On Sun, Dec 08, 2013 at 03:43:12PM +0100, Borislav Petkov wrote: > On Sun, Dec 08, 2013 at 12:17:53PM +0800, Rui Wang wrote: > > There's inconsistency between dmesg and the trace event output. > > When dmesg says "severity=Corrected", the trace event says > > "severity=Fatal". What happens is that

Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-08 Thread Borislav Petkov
On Sun, Dec 08, 2013 at 12:17:53PM +0800, Rui Wang wrote: > There's inconsistency between dmesg and the trace event output. > When dmesg says "severity=Corrected", the trace event says > "severity=Fatal". What happens is that HW_EVENT_ERR_CORRECTED is > defined in edac.h: > > enum

Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-08 Thread Borislav Petkov
On Sun, Dec 08, 2013 at 12:17:53PM +0800, Rui Wang wrote: There's inconsistency between dmesg and the trace event output. When dmesg says severity=Corrected, the trace event says severity=Fatal. What happens is that HW_EVENT_ERR_CORRECTED is defined in edac.h: enum hw_event_mc_err_type {

Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-08 Thread Borislav Petkov
On Sun, Dec 08, 2013 at 03:43:12PM +0100, Borislav Petkov wrote: On Sun, Dec 08, 2013 at 12:17:53PM +0800, Rui Wang wrote: There's inconsistency between dmesg and the trace event output. When dmesg says severity=Corrected, the trace event says severity=Fatal. What happens is that

Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-07 Thread Ethan Zhao
Rui, I like this patch. thanks your revision. Ethan On Sun, Dec 8, 2013 at 12:17 PM, Rui Wang wrote: > There's inconsistency between dmesg and the trace event output. > When dmesg says "severity=Corrected", the trace event says > "severity=Fatal". What happens is that HW_EVENT_ERR_CORRECTED

[PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-07 Thread Rui Wang
There's inconsistency between dmesg and the trace event output. When dmesg says "severity=Corrected", the trace event says "severity=Fatal". What happens is that HW_EVENT_ERR_CORRECTED is defined in edac.h: enum hw_event_mc_err_type { HW_EVENT_ERR_CORRECTED,

[PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-07 Thread Rui Wang
There's inconsistency between dmesg and the trace event output. When dmesg says severity=Corrected, the trace event says severity=Fatal. What happens is that HW_EVENT_ERR_CORRECTED is defined in edac.h: enum hw_event_mc_err_type { HW_EVENT_ERR_CORRECTED, HW_EVENT_ERR_UNCORRECTED,

Re: [PATCH] aerdrv: Fix severity usage in aer trace event

2013-12-07 Thread Ethan Zhao
Rui, I like this patch. thanks your revision. Ethan On Sun, Dec 8, 2013 at 12:17 PM, Rui Wang ruiv.w...@gmail.com wrote: There's inconsistency between dmesg and the trace event output. When dmesg says severity=Corrected, the trace event says severity=Fatal. What happens is that