Markus Elfring wrote:
> > sysnames should be freed after refcnt being decreased to zero in
> > afs_put_sysnames().
>
> * I suggest to use the wording “reference counter”.
Can you use ASCII quotes please? Not all fonts contain these quotes, and
occasionally they got copied into commit
Zhihao Cheng wrote:
> sysnames should be freed after refcnt being decreased to zero in
> afs_put_sysnames().
Good catch.
> Besides, it would be better set net->sysnames to 'NULL' after net->sysnames
> being released if afs_put_sysnames() aims on an afs_sysnames object.
Why? We don't normally
> sysnames should be freed after refcnt being decreased to zero in
> afs_put_sysnames().
* I suggest to use the wording “reference counter”.
* Where did you notice a “memory leak” here?
> Besides, it would be better set net->sysnames
> to 'NULL' after net->sysnames being released if
sysnames should be freed after refcnt being decreased to zero in
afs_put_sysnames(). Besides, it would be better set net->sysnames
to 'NULL' after net->sysnames being released if afs_put_sysnames()
aims on an afs_sysnames object.
Signed-off-by: Zhihao Cheng
Cc: # v4.17+
Fixes: 6f8880d8e681557
4 matches
Mail list logo