Re: [PATCH] afs: Fix memory leak in afs_put_sysnames()

2020-06-01 Thread David Howells
Markus Elfring wrote: > > sysnames should be freed after refcnt being decreased to zero in > > afs_put_sysnames(). > > * I suggest to use the wording “reference counter”. Can you use ASCII quotes please? Not all fonts contain these quotes, and occasionally they got copied into commit

Re: [PATCH] afs: Fix memory leak in afs_put_sysnames()

2020-06-01 Thread David Howells
Zhihao Cheng wrote: > sysnames should be freed after refcnt being decreased to zero in > afs_put_sysnames(). Good catch. > Besides, it would be better set net->sysnames to 'NULL' after net->sysnames > being released if afs_put_sysnames() aims on an afs_sysnames object. Why? We don't normally

Re: [PATCH] afs: Fix memory leak in afs_put_sysnames()

2020-06-01 Thread Markus Elfring
> sysnames should be freed after refcnt being decreased to zero in > afs_put_sysnames(). * I suggest to use the wording “reference counter”. * Where did you notice a “memory leak” here? > Besides, it would be better set net->sysnames > to 'NULL' after net->sysnames being released if

[PATCH] afs: Fix memory leak in afs_put_sysnames()

2020-06-01 Thread Zhihao Cheng
sysnames should be freed after refcnt being decreased to zero in afs_put_sysnames(). Besides, it would be better set net->sysnames to 'NULL' after net->sysnames being released if afs_put_sysnames() aims on an afs_sysnames object. Signed-off-by: Zhihao Cheng Cc: # v4.17+ Fixes: 6f8880d8e681557