Re: [PATCH] aio: partial write should not return error code.

2008-01-04 Thread Zach Brown
> > No, that's fine, here is the new one: > > When an AIO write gets a non-retry error after writing some data > (eg. ENOSPC), it should return the amount written already, not the > error. Just like write() is supposed to. > > This was found by the libaio test suite. > > Signed-off-by: Rusty

Re: [PATCH] aio: partial write should not return error code.

2008-01-04 Thread Zach Brown
No, that's fine, here is the new one: When an AIO write gets a non-retry error after writing some data (eg. ENOSPC), it should return the amount written already, not the error. Just like write() is supposed to. This was found by the libaio test suite. Signed-off-by: Rusty Russell

Re: [PATCH] aio: partial write should not return error code.

2008-01-03 Thread Rusty Russell
On Friday 04 January 2008 07:04:30 Zach Brown wrote: > Rusty Russell wrote: > > When an AIO write gets an error after writing some data (eg. ENOSPC), > > it should return the amount written already, not the error. Just like > > write() is supposed to. > > Andrew, please don't queue this fix. I

Re: [PATCH] aio: partial write should not return error code.

2008-01-03 Thread Zach Brown
Rusty Russell wrote: > When an AIO write gets an error after writing some data (eg. ENOSPC), > it should return the amount written already, not the error. Just like > write() is supposed to. Andrew, please don't queue this fix. I think the bug is valid but the patch is subtly dangerous. > diff

[PATCH] aio: partial write should not return error code.

2008-01-03 Thread Rusty Russell
When an AIO write gets an error after writing some data (eg. ENOSPC), it should return the amount written already, not the error. Just like write() is supposed to. This was found by the libaio test suite. Signed-off-by: Rusty Russell <[EMAIL PROTECTED]> diff -r 18802689361a fs/aio.c ---

[PATCH] aio: partial write should not return error code.

2008-01-03 Thread Rusty Russell
When an AIO write gets an error after writing some data (eg. ENOSPC), it should return the amount written already, not the error. Just like write() is supposed to. This was found by the libaio test suite. Signed-off-by: Rusty Russell [EMAIL PROTECTED] diff -r 18802689361a fs/aio.c ---

Re: [PATCH] aio: partial write should not return error code.

2008-01-03 Thread Zach Brown
Rusty Russell wrote: When an AIO write gets an error after writing some data (eg. ENOSPC), it should return the amount written already, not the error. Just like write() is supposed to. Andrew, please don't queue this fix. I think the bug is valid but the patch is subtly dangerous. diff -r