Re: [PATCH] alarmtimer: add .remove_dev hook to put device

2012-07-18 Thread John Stultz
On 07/18/2012 06:23 PM, Shawn Guo wrote: On 19 July 2012 07:23, John Stultz wrote: Actually, this change opens up a bunch of other races, as any caller of alarmtimer_get_rtcdev() could have the rtcdevice removed under it. We'll need to have proper reference counting w/ get/put calls, probably

Re: [PATCH] alarmtimer: add .remove_dev hook to put device

2012-07-18 Thread Shawn Guo
On 19 July 2012 07:23, John Stultz wrote: > Actually, this change opens up a bunch of other races, as any caller of > alarmtimer_get_rtcdev() could have the rtcdevice removed under it. > > We'll need to have proper reference counting w/ get/put calls, probably also > adding a alarmtimer_put_rtcdev

Re: [PATCH] alarmtimer: add .remove_dev hook to put device

2012-07-18 Thread John Stultz
On 07/18/2012 04:16 PM, John Stultz wrote: On 07/04/2012 09:13 AM, Shawn Guo wrote: The following is a test sequence that installs a rtc module, remove it and installs it again. $ insmod rtc-snvs.ko snvs_rtc 20cc034.snvs-rtc-lp: rtc core: registered 20cc034.snvs-rtc-lp as rtc0 $ hwclock Thu J

Re: [PATCH] alarmtimer: add .remove_dev hook to put device

2012-07-18 Thread John Stultz
On 07/04/2012 09:13 AM, Shawn Guo wrote: The following is a test sequence that installs a rtc module, remove it and installs it again. $ insmod rtc-snvs.ko snvs_rtc 20cc034.snvs-rtc-lp: rtc core: registered 20cc034.snvs-rtc-lp as rtc0 $ hwclock Thu Jul 5 08:53:35 2012 0.00 seconds $ rmmod

Re: [PATCH] alarmtimer: add .remove_dev hook to put device

2012-07-10 Thread John Stultz
On 07/10/2012 08:46 PM, Shawn Guo wrote: Hi John, Is this patch a valid fix or just a noise? Sorry! This is on my list, but I've not had a chance to get to it. I'll try to get a closer look later this week! Thanks for reminding me, and sorry again! -john Regards, Shawn On Thu, Jul 05, 20

Re: [PATCH] alarmtimer: add .remove_dev hook to put device

2012-07-10 Thread Shawn Guo
Hi John, Is this patch a valid fix or just a noise? Regards, Shawn On Thu, Jul 05, 2012 at 12:13:07AM +0800, Shawn Guo wrote: > The following is a test sequence that installs a rtc module, remove it > and installs it again. > > $ insmod rtc-snvs.ko > snvs_rtc 20cc034.snvs-rtc-lp: rtc core: regi