Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-29 Thread Pavel Machek
On Thu 2014-05-15 20:10:13, Paul Bolle wrote: > Daniel, > > On Thu, 2014-05-15 at 17:44 +, dwal...@fifo99.com wrote: > > On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote: > > > Commit 1b802ff79f03 ("arm: msm: add board file for Nexus One (ie. > > > mahimahi)") added just

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-29 Thread Pavel Machek
On Thu 2014-05-15 20:10:13, Paul Bolle wrote: Daniel, On Thu, 2014-05-15 at 17:44 +, dwal...@fifo99.com wrote: On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote: Commit 1b802ff79f03 (arm: msm: add board file for Nexus One (ie. mahimahi)) added just board-mahimahi.c. It did

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-20 Thread Ivan T. Ivanov
On Mon, 2014-05-19 at 14:30 +, dwal...@fifo99.com wrote: > On Mon, May 19, 2014 at 01:53:28PM +0200, Paul Bolle wrote: > > > Even the most dubious of code in drivers/staging is expected to "compile > > properly"! > > But mach-msm isn't staging, different rules apply there. Heh, different

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-20 Thread Ivan T. Ivanov
On Mon, 2014-05-19 at 14:30 +, dwal...@fifo99.com wrote: On Mon, May 19, 2014 at 01:53:28PM +0200, Paul Bolle wrote: snip Even the most dubious of code in drivers/staging is expected to compile properly! But mach-msm isn't staging, different rules apply there. Heh, different rules

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-19 Thread dwalker
On Mon, May 19, 2014 at 01:53:28PM +0200, Paul Bolle wrote: > Daniel, > > On Thu, 2014-05-15 at 21:57 +, dwal...@fifo99.com wrote: > > On Thu, May 15, 2014 at 08:10:13PM +0200, Paul Bolle wrote: > > > This is not something I get to decide. Nevertheless, given that this > > > file shouldn't

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-19 Thread Paul Bolle
Daniel, On Thu, 2014-05-15 at 21:57 +, dwal...@fifo99.com wrote: > On Thu, May 15, 2014 at 08:10:13PM +0200, Paul Bolle wrote: > > This is not something I get to decide. Nevertheless, given that this > > file shouldn't have been merged to begin with, I'd appreciate it if some > > deadline

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-19 Thread Paul Bolle
Daniel, On Thu, 2014-05-15 at 21:57 +, dwal...@fifo99.com wrote: On Thu, May 15, 2014 at 08:10:13PM +0200, Paul Bolle wrote: This is not something I get to decide. Nevertheless, given that this file shouldn't have been merged to begin with, I'd appreciate it if some deadline could be

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-19 Thread dwalker
On Mon, May 19, 2014 at 01:53:28PM +0200, Paul Bolle wrote: Daniel, On Thu, 2014-05-15 at 21:57 +, dwal...@fifo99.com wrote: On Thu, May 15, 2014 at 08:10:13PM +0200, Paul Bolle wrote: This is not something I get to decide. Nevertheless, given that this file shouldn't have been

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-15 Thread dwalker
On Thu, May 15, 2014 at 08:10:13PM +0200, Paul Bolle wrote: > Daniel, > > On Thu, 2014-05-15 at 17:44 +, dwal...@fifo99.com wrote: > > On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote: > > > Commit 1b802ff79f03 ("arm: msm: add board file for Nexus One (ie. > > > mahimahi)") added

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-15 Thread Paul Bolle
Daniel, On Thu, 2014-05-15 at 17:44 +, dwal...@fifo99.com wrote: > On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote: > > Commit 1b802ff79f03 ("arm: msm: add board file for Nexus One (ie. > > mahimahi)") added just board-mahimahi.c. It did not add > > board-mahimahi.h, Makefile

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-15 Thread dwalker
On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote: > Commit 1b802ff79f03 ("arm: msm: add board file for Nexus One (ie. > mahimahi)") added just board-mahimahi.c. It did not add > board-mahimahi.h, Makefile changes or Kconfig changes. > > Four years have passed and this file is still

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-15 Thread dwalker
On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote: Commit 1b802ff79f03 (arm: msm: add board file for Nexus One (ie. mahimahi)) added just board-mahimahi.c. It did not add board-mahimahi.h, Makefile changes or Kconfig changes. Four years have passed and this file is still dangling.

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-15 Thread Paul Bolle
Daniel, On Thu, 2014-05-15 at 17:44 +, dwal...@fifo99.com wrote: On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote: Commit 1b802ff79f03 (arm: msm: add board file for Nexus One (ie. mahimahi)) added just board-mahimahi.c. It did not add board-mahimahi.h, Makefile changes or

Re: [PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-15 Thread dwalker
On Thu, May 15, 2014 at 08:10:13PM +0200, Paul Bolle wrote: Daniel, On Thu, 2014-05-15 at 17:44 +, dwal...@fifo99.com wrote: On Wed, May 14, 2014 at 11:07:36PM +0200, Paul Bolle wrote: Commit 1b802ff79f03 (arm: msm: add board file for Nexus One (ie. mahimahi)) added just

[PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-14 Thread Paul Bolle
Commit 1b802ff79f03 ("arm: msm: add board file for Nexus One (ie. mahimahi)") added just board-mahimahi.c. It did not add board-mahimahi.h, Makefile changes or Kconfig changes. Four years have passed and this file is still dangling. Remove it. Signed-off-by: Paul Bolle --- Untested. But what to

[PATCH] arm: msm: remove board file for Nexus One (ie. mahimahi)

2014-05-14 Thread Paul Bolle
Commit 1b802ff79f03 (arm: msm: add board file for Nexus One (ie. mahimahi)) added just board-mahimahi.c. It did not add board-mahimahi.h, Makefile changes or Kconfig changes. Four years have passed and this file is still dangling. Remove it. Signed-off-by: Paul Bolle pebo...@tiscali.nl ---