Re: [PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

2018-08-13 Thread zhong jiang
On 2018/8/13 20:28, Vladimir Zapolskiy wrote: > Hi zhong jiang, > > On 08/10/2018 05:40 AM, zhong jiang wrote: >> kmemdup is better than kmalloc() + memcpy(), and we do not like >> open code. So just use kmemdup instead. >> >> Signed-off-by: zhong jiang >> --- >> arch/arm/mach-lpc32xx/pm.c | 7

Re: [PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

2018-08-13 Thread zhong jiang
On 2018/8/13 20:28, Vladimir Zapolskiy wrote: > Hi zhong jiang, > > On 08/10/2018 05:40 AM, zhong jiang wrote: >> kmemdup is better than kmalloc() + memcpy(), and we do not like >> open code. So just use kmemdup instead. >> >> Signed-off-by: zhong jiang >> --- >> arch/arm/mach-lpc32xx/pm.c | 7

Re: [PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

2018-08-13 Thread Vladimir Zapolskiy
Hi zhong jiang, On 08/10/2018 05:40 AM, zhong jiang wrote: > kmemdup is better than kmalloc() + memcpy(), and we do not like > open code. So just use kmemdup instead. > > Signed-off-by: zhong jiang > --- > arch/arm/mach-lpc32xx/pm.c | 7 ++- > 1 file changed, 2 insertions(+), 5

Re: [PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

2018-08-13 Thread Vladimir Zapolskiy
Hi zhong jiang, On 08/10/2018 05:40 AM, zhong jiang wrote: > kmemdup is better than kmalloc() + memcpy(), and we do not like > open code. So just use kmemdup instead. > > Signed-off-by: zhong jiang > --- > arch/arm/mach-lpc32xx/pm.c | 7 ++- > 1 file changed, 2 insertions(+), 5

[PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

2018-08-09 Thread zhong jiang
kmemdup is better than kmalloc() + memcpy(), and we do not like open code. So just use kmemdup instead. Signed-off-by: zhong jiang --- arch/arm/mach-lpc32xx/pm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-lpc32xx/pm.c b/arch/arm/mach-lpc32xx/pm.c

[PATCH] arm:pm: Use kmemdup to replace duplicating its implementation

2018-08-09 Thread zhong jiang
kmemdup is better than kmalloc() + memcpy(), and we do not like open code. So just use kmemdup instead. Signed-off-by: zhong jiang --- arch/arm/mach-lpc32xx/pm.c | 7 ++- 1 file changed, 2 insertions(+), 5 deletions(-) diff --git a/arch/arm/mach-lpc32xx/pm.c b/arch/arm/mach-lpc32xx/pm.c