Re: [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION

2020-12-17 Thread Lecopzer Chen
Hi Catalin, Thanks for your explanation. > > so there is two points > > 1. out-of-tree function can't be approved > > I totally agree with this :) so we may have a driver upstream in the > > future. > > It may not be upstreamable if it relies on the old APM interface ;). > > > 2. APM

Re: [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION

2020-12-17 Thread Catalin Marinas
On Thu, Dec 17, 2020 at 12:41:47AM +0800, Lecopzer Chen wrote: > so there is two points > 1. out-of-tree function can't be approved > I totally agree with this :) so we may have a driver upstream in the > future. It may not be upstreamable if it relies on the old APM interface ;). > 2. APM

Re: [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION

2020-12-16 Thread Lecopzer Chen
Hi Catalin, Thanks for your reply. so there is two points 1. out-of-tree function can't be approved I totally agree with this :) so we may have a driver upstream in the future. 2. APM not make sense on arm64 Could you please let me konw the reason why APM on ARM64 doesn't make sense?

Re: [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION

2020-12-16 Thread Catalin Marinas
On Wed, Nov 25, 2020 at 07:41:30PM +0800, Lecopzer Chen wrote: > >> In order to select CONFIG_APM_EMULATION, make SYS_SUPPORTS_APM_EMULATION > >> default is y if ACPI isn't configured. > > > >I'm a bit confused why this should be enabled for !ACPI. Which DT > >platforms need this, and how do they

Re: [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION

2020-12-14 Thread Lecopzer Chen
Hi, Could any maintainer help review this? Thanks a lot for your help, BRs, Lecopzer > Although most of modern devices use ACPI, there still has combination > of APM + ARM64. > > In order to select CONFIG_APM_EMULATION, make SYS_SUPPORTS_APM_EMULATION > default is y if ACPI isn't configured.

Re: [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION

2020-11-25 Thread Lecopzer Chen
>> From: "Lecopzer Chen" >> >> Although most of modern devices use ACPI, there still has combination >> of APM + ARM64. >> >> In order to select CONFIG_APM_EMULATION, make SYS_SUPPORTS_APM_EMULATION >> default is y if ACPI isn't configured. > >I'm a bit confused why this should be enabled for

Re: [PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION

2020-11-25 Thread Mark Rutland
On Tue, Nov 24, 2020 at 05:01:31PM +0800, Lecopzer Chen wrote: > From: "Lecopzer Chen" > > Although most of modern devices use ACPI, there still has combination > of APM + ARM64. > > In order to select CONFIG_APM_EMULATION, make SYS_SUPPORTS_APM_EMULATION > default is y if ACPI isn't

[PATCH] arm64: Kconfig: Add SYS_SUPPORTS_APM_EMULATION

2020-11-24 Thread Lecopzer Chen
From: "Lecopzer Chen" Although most of modern devices use ACPI, there still has combination of APM + ARM64. In order to select CONFIG_APM_EMULATION, make SYS_SUPPORTS_APM_EMULATION default is y if ACPI isn't configured. Signed-off-by: Lecopzer Chen Suggested-by: YJ Chiang ---