Re: [PATCH] arm64: fix alternatives with LLVM's integrated assembler

2019-10-15 Thread Nick Desaulniers
On Mon, Oct 7, 2019 at 4:47 PM Sami Tolvanen wrote: > > On Mon, Oct 7, 2019 at 2:34 PM Nick Desaulniers > wrote: > > Should the definition of the ALTERNATIVE macro > > (arch/arm64/include/asm/alternative.h#L295) also be updated in this > > patch to not pass `1` as the final parameter? > > No, th

Re: [PATCH] arm64: fix alternatives with LLVM's integrated assembler

2019-10-15 Thread Nick Desaulniers
On Mon, Oct 14, 2019 at 5:00 PM Will Deacon wrote: > > On Mon, Oct 07, 2019 at 04:47:20PM -0700, Sami Tolvanen wrote: > > On Mon, Oct 7, 2019 at 2:34 PM Nick Desaulniers > > wrote: > > > Should the definition of the ALTERNATIVE macro > > > (arch/arm64/include/asm/alternative.h#L295) also be upda

Re: [PATCH] arm64: fix alternatives with LLVM's integrated assembler

2019-10-14 Thread Sami Tolvanen
On Mon, Oct 14, 2019 at 5:00 PM Will Deacon wrote: > Is there any benefit from supporting '-no-integrated-as' but not 'AS=clang'? > afaict, you have to hack the top-level Makefile for that. The goal is to eventually support AS=clang and this patch gets us one step closer to that. However, with th

Re: [PATCH] arm64: fix alternatives with LLVM's integrated assembler

2019-10-14 Thread Will Deacon
On Mon, Oct 07, 2019 at 04:47:20PM -0700, Sami Tolvanen wrote: > On Mon, Oct 7, 2019 at 2:34 PM Nick Desaulniers > wrote: > > Should the definition of the ALTERNATIVE macro > > (arch/arm64/include/asm/alternative.h#L295) also be updated in this > > patch to not pass `1` as the final parameter? >

Re: [PATCH] arm64: fix alternatives with LLVM's integrated assembler

2019-10-07 Thread Sami Tolvanen
On Mon, Oct 7, 2019 at 2:34 PM Nick Desaulniers wrote: > Should the definition of the ALTERNATIVE macro > (arch/arm64/include/asm/alternative.h#L295) also be updated in this > patch to not pass `1` as the final parameter? No, that's the default value for cfg in case the caller omits the parameter

Re: [PATCH] arm64: fix alternatives with LLVM's integrated assembler

2019-10-07 Thread Nick Desaulniers
On Mon, Oct 7, 2019 at 2:14 PM 'Sami Tolvanen' via Clang Built Linux wrote: > > LLVM's integrated assembler fails with the following error when > building KVM: > > :12:6: error: expected absolute expression >.if kvm_update_va_mask == 0 >^ > :21:6: error: expected absolute expressio

[PATCH] arm64: fix alternatives with LLVM's integrated assembler

2019-10-07 Thread Sami Tolvanen
LLVM's integrated assembler fails with the following error when building KVM: :12:6: error: expected absolute expression .if kvm_update_va_mask == 0 ^ :21:6: error: expected absolute expression .if kvm_update_va_mask == 0 ^ :24:2: error: unrecognized instruction mnemonic