Re: [PATCH] arm64: futex: Restore oldval initialization to work around buggy compilers

2019-04-17 Thread Catalin Marinas
On Wed, Apr 17, 2019 at 12:21:21AM -0700, Nathan Chancellor wrote: > Commit 045afc24124d ("arm64: futex: Fix FUTEX_WAKE_OP atomic ops with > non-zero result value") removed oldval's zero initialization in > arch_futex_atomic_op_inuser because it is not necessary. Unfortunately, > Android's arm64

Re: [PATCH] arm64: futex: Restore oldval initialization to work around buggy compilers

2019-04-17 Thread Greg Kroah-Hartman
On Wed, Apr 17, 2019 at 12:21:21AM -0700, Nathan Chancellor wrote: > Commit 045afc24124d ("arm64: futex: Fix FUTEX_WAKE_OP atomic ops with > non-zero result value") removed oldval's zero initialization in > arch_futex_atomic_op_inuser because it is not necessary. Unfortunately, > Android's arm64

[PATCH] arm64: futex: Restore oldval initialization to work around buggy compilers

2019-04-17 Thread Nathan Chancellor
Commit 045afc24124d ("arm64: futex: Fix FUTEX_WAKE_OP atomic ops with non-zero result value") removed oldval's zero initialization in arch_futex_atomic_op_inuser because it is not necessary. Unfortunately, Android's arm64 GCC 4.9.4 [1] does not agree: ../kernel/futex.c: In function 'do_futex':