Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

On 11/10/2015 2:37 AM, Catalin Marinas wrote: On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory is never used. That's not true

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

On Tue, Nov 10, 2015 at 07:43:35PM +0800, yalin wang wrote: > > On Nov 10, 2015, at 19:35, Catalin Marinas wrote: > > On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote: > >> i have a question, > >> why FRAME_POINTER config must be enabled ? > >> and i see ARM arch can disable this

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

> On Nov 10, 2015, at 19:35, Catalin Marinas wrote: > > On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote: >>> On Nov 10, 2015, at 18:37, Catalin Marinas wrote: >>> >>> On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: FRAME_POINTER is defined in lib/Kconfig.debug, it

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote: > > On Nov 10, 2015, at 18:37, Catalin Marinas wrote: > > > > On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: > >> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to > >> redefine > >> it in

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

> On Nov 10, 2015, at 18:37, Catalin Marinas wrote: > > On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: >> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine >> it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory >> is never used. >

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine > it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory > is never used. That's not true since the arm64 definition seems to take

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

On 11/10/2015 2:37 AM, Catalin Marinas wrote: On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory is never used. That's not true

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine > it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory > is never used. That's not true since the arm64 definition seems to take

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

> On Nov 10, 2015, at 19:35, Catalin Marinas wrote: > > On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote: >>> On Nov 10, 2015, at 18:37, Catalin Marinas wrote: >>> >>> On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote:

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

> On Nov 10, 2015, at 18:37, Catalin Marinas wrote: > > On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: >> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine >> it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote: > > On Nov 10, 2015, at 18:37, Catalin Marinas wrote: > > > > On Mon, Nov 09, 2015 at 10:09:55AM -0800, Yang Shi wrote: > >> FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to > >> redefine >

Re: [V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

On Tue, Nov 10, 2015 at 07:43:35PM +0800, yalin wang wrote: > > On Nov 10, 2015, at 19:35, Catalin Marinas wrote: > > On Tue, Nov 10, 2015 at 07:09:00PM +0800, yalin wang wrote: > >> i have a question, > >> why FRAME_POINTER config must be enabled ? > >> and i see ARM

[V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory is never used. This adds a dependency on DEBUG_KERNEL for building with frame pointers. ARM64 depends on frame pointer to get correct stack

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 09:55:54AM -0800, Shi, Yang wrote: > On 11/6/2015 9:51 AM, Catalin Marinas wrote: > >On Fri, Nov 06, 2015 at 09:39:07AM -0800, Shi, Yang wrote: > >>On 11/6/2015 9:35 AM, Catalin Marinas wrote: > >>>On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: > On

[V3 PATCH] arm64: remove redundant FRAME_POINTER kconfig option and force to select it

FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine it in arch/arm64/Kconfig.debug. Actually, the one defined in arm64 directory is never used. This adds a dependency on DEBUG_KERNEL for building with frame pointers. ARM64 depends on frame pointer to get correct stack

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 09:55:54AM -0800, Shi, Yang wrote: > On 11/6/2015 9:51 AM, Catalin Marinas wrote: > >On Fri, Nov 06, 2015 at 09:39:07AM -0800, Shi, Yang wrote: > >>On 11/6/2015 9:35 AM, Catalin Marinas wrote: > >>>On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: > On

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On 11/6/2015 9:51 AM, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 09:39:07AM -0800, Shi, Yang wrote: On 11/6/2015 9:35 AM, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: On 11/6/2015 8:25 AM, Will Deacon wrote: However, the patch would allow one to

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 09:39:07AM -0800, Shi, Yang wrote: > On 11/6/2015 9:35 AM, Catalin Marinas wrote: > >On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: > >>On 11/6/2015 8:25 AM, Will Deacon wrote: > >>>However, the patch would allow one to > >>>disable FRAME_POINTERS (not sure it

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On 11/6/2015 9:35 AM, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: On 11/6/2015 8:25 AM, Will Deacon wrote: However, the patch would allow one to disable FRAME_POINTERS (not sure it has any effect on the aarch64 gcc though). No, it doesn't. Actually,

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: > On 11/6/2015 8:25 AM, Will Deacon wrote: > >However, the patch would allow one to > >disable FRAME_POINTERS (not sure it has any effect on the aarch64 gcc > >though). > > No, it doesn't. Actually, FRAME_POINTER could be disabled

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On 11/6/2015 8:25 AM, Will Deacon wrote: On Fri, Nov 06, 2015 at 04:21:09PM +, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 12:50:02PM +, Mark Rutland wrote: On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote:

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 04:21:09PM +, Catalin Marinas wrote: > On Fri, Nov 06, 2015 at 12:50:02PM +, Mark Rutland wrote: > > On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > > > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > > > FRAME_POINTER is defined in

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 12:50:02PM +, Mark Rutland wrote: > On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to > > > redefine > > > it in

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 04:12:14PM +, Catalin Marinas wrote: > On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to > > > redefine > > > it in

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine > > it in arch/arm64/Kconfig.debug. > > It might be worth noting that this adds a dependency on

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 12:50:02PM +, Mark Rutland wrote: > On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to > > > redefine > > > it in

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine > > it in arch/arm64/Kconfig.debug. > > It might be worth noting that this adds a dependency on

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine > it in arch/arm64/Kconfig.debug. It might be worth noting that this adds a dependency on DEBUG_KERNEL for building with frame pointers. I'm ok with that (it

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 12:50:02PM +, Mark Rutland wrote: > On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to > > > redefine > > > it in

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine > > it in arch/arm64/Kconfig.debug. > > It might be worth noting that this adds a dependency on

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 04:12:14PM +, Catalin Marinas wrote: > On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to > > > redefine > > > it in

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 12:50:02PM +, Mark Rutland wrote: > On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to > > > redefine > > > it in

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 04:21:09PM +, Catalin Marinas wrote: > On Fri, Nov 06, 2015 at 12:50:02PM +, Mark Rutland wrote: > > On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > > > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > > > FRAME_POINTER is defined in

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On 11/6/2015 8:25 AM, Will Deacon wrote: On Fri, Nov 06, 2015 at 04:21:09PM +, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 12:50:02PM +, Mark Rutland wrote: On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote:

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine > it in arch/arm64/Kconfig.debug. It might be worth noting that this adds a dependency on DEBUG_KERNEL for building with frame pointers. I'm ok with that (it

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: > On 11/6/2015 8:25 AM, Will Deacon wrote: > >However, the patch would allow one to > >disable FRAME_POINTERS (not sure it has any effect on the aarch64 gcc > >though). > > No, it doesn't. Actually, FRAME_POINTER could be disabled

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 12:30:09PM +, Will Deacon wrote: > On Wed, Nov 04, 2015 at 09:37:51AM -0800, Yang Shi wrote: > > FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine > > it in arch/arm64/Kconfig.debug. > > It might be worth noting that this adds a dependency on

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On 11/6/2015 9:35 AM, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: On 11/6/2015 8:25 AM, Will Deacon wrote: However, the patch would allow one to disable FRAME_POINTERS (not sure it has any effect on the aarch64 gcc though). No, it doesn't. Actually,

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On Fri, Nov 06, 2015 at 09:39:07AM -0800, Shi, Yang wrote: > On 11/6/2015 9:35 AM, Catalin Marinas wrote: > >On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: > >>On 11/6/2015 8:25 AM, Will Deacon wrote: > >>>However, the patch would allow one to > >>>disable FRAME_POINTERS (not sure it

Re: [PATCH] arm64: remove redundant FRAME_POINTER kconfig option

On 11/6/2015 9:51 AM, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 09:39:07AM -0800, Shi, Yang wrote: On 11/6/2015 9:35 AM, Catalin Marinas wrote: On Fri, Nov 06, 2015 at 09:23:38AM -0800, Shi, Yang wrote: On 11/6/2015 8:25 AM, Will Deacon wrote: However, the patch would allow one to

[PATCH] arm64: remove redundant FRAME_POINTER kconfig option

FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine it in arch/arm64/Kconfig.debug. Signed-off-by: Yang Shi --- arch/arm64/Kconfig.debug | 4 1 file changed, 4 deletions(-) diff --git a/arch/arm64/Kconfig.debug b/arch/arm64/Kconfig.debug index d6285ef..915dea7

[PATCH] arm64: remove redundant FRAME_POINTER kconfig option

FRAME_POINTER is defined in lib/Kconfig.debug, it is unnecessary to redefine it in arch/arm64/Kconfig.debug. Signed-off-by: Yang Shi --- arch/arm64/Kconfig.debug | 4 1 file changed, 4 deletions(-) diff --git a/arch/arm64/Kconfig.debug b/arch/arm64/Kconfig.debug index