Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-09 Thread Prakash Punnoor
Am Montag 09 Juli 2007 schrieb Peer Chen: > It's a rule for all our drivers not just for linux, also if we put the > Maxtor drive to the blacklist so that its NCQ function won't be enable for > all controllers of other vendors,but we don't have the strong evidence that > those Maxtor HDDs are also

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-09 Thread Prakash Punnoor
Am Montag 09 Juli 2007 schrieb Peer Chen: It's a rule for all our drivers not just for linux, also if we put the Maxtor drive to the blacklist so that its NCQ function won't be enable for all controllers of other vendors,but we don't have the strong evidence that those Maxtor HDDs are also

RE: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-08 Thread Peer Chen
It's a rule for all our drivers not just for linux, also if we put the Maxtor drive to the blacklist so that its NCQ function won't be enable for all controllers of other vendors,but we don't have the strong evidence that those Maxtor HDDs are also broken for other controllers. BRs Peer Chen

RE: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-08 Thread Peer Chen
It's a rule for all our drivers not just for linux, also if we put the Maxtor drive to the blacklist so that its NCQ function won't be enable for all controllers of other vendors,but we don't have the strong evidence that those Maxtor HDDs are also broken for other controllers. BRs Peer Chen

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-07 Thread Zoltan Boszormenyi
kuan luo írta: From: Kuan Luo <[EMAIL PROTECTED]> Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1'. NCQ will be turned off if the drive is Maxtor on MCP51 or MCP55 rev 0xa2 platform.

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-07 Thread Zoltan Boszormenyi
kuan luo írta: From: Kuan Luo [EMAIL PROTECTED] Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1'. NCQ will be turned off if the drive is Maxtor on MCP51 or MCP55 rev 0xa2 platform.

[PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-06 Thread kuan luo
From: Kuan Luo <[EMAIL PROTECTED]> Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1'. NCQ will be turned off if the drive is Maxtor on MCP51 or MCP55 rev 0xa2 platform. Signed-off-by: Kuan Luo

[PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-06 Thread kuan luo
From: Kuan Luo [EMAIL PROTECTED] Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1'. NCQ will be turned off if the drive is Maxtor on MCP51 or MCP55 rev 0xa2 platform. Signed-off-by: Kuan Luo

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-05 Thread Bill Davidsen
Zoltan Boszormenyi wrote: Hi, Zoltan Boszormenyi írta: Hi, I am testing your current code with akpm's beautifying patches for about an hour now. I have seen no problems with it so far. Still using the patch on 2.6.22-rc6 and no problems so far. It's really stable. I am looking forward to

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-05 Thread Bill Davidsen
Zoltan Boszormenyi wrote: Hi, Zoltan Boszormenyi írta: Hi, I am testing your current code with akpm's beautifying patches for about an hour now. I have seen no problems with it so far. Still using the patch on 2.6.22-rc6 and no problems so far. It's really stable. I am looking forward to

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-03 Thread Zoltan Boszormenyi
Hi, Zoltan Boszormenyi írta: Hi, I am testing your current code with akpm's beautifying patches for about an hour now. I have seen no problems with it so far. Still using the patch on 2.6.22-rc6 and no problems so far. It's really stable. I am looking forward to the next version and the

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-07-03 Thread Zoltan Boszormenyi
Hi, Zoltan Boszormenyi írta: Hi, I am testing your current code with akpm's beautifying patches for about an hour now. I have seen no problems with it so far. Still using the patch on 2.6.22-rc6 and no problems so far. It's really stable. I am looking forward to the next version and the

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Prakash Punnoor
Am Mittwoch 27 Juni 2007 schrieb Peer Chen: > We did the many test with the new version driver and didn't encounter > that problem, but in certain cases, DMASETUP command packets from drive > to the controller are corrupted, and the controller issues an R_ERR to > the drive. Drives that comply

RE: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Zoltan Boszormenyi
Hi, I am testing your current code with akpm's beautifying patches for about an hour now. I have seen no problems with it so far. **A pretty good way. I will modify my code. Please, cc me when sending your next patch to LKML, thanks. Best regards, Zoltán Böszörményi - To unsubscribe

RE: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Kuan Luo
A pretty good way. I will modify my code. -Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 27, 2007 5:21 PM To: Kuan Luo Cc: linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; Peer Chen Subject: Re: [PATCH] ata: Add the SW NCQ support to sata_nv for

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Andrew Morton
On Wed, 27 Jun 2007 17:09:29 +0800 "Kuan Luo" <[EMAIL PROTECTED]> wrote: > > +static void nv_swncq_qc_to_dq(struct ata_port *ap, struct > ata_queued_cmd *qc) > > +{ > > + struct nv_swncq_port_priv *pp = ap->private_data; > > + defer_queue_t *dq = >defer_queue; > > + > > + /* queue is

RE: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Kuan Luo
> +static void nv_swncq_qc_to_dq(struct ata_port *ap, struct ata_queued_cmd *qc) > +{ > + struct nv_swncq_port_priv *pp = ap->private_data; > + defer_queue_t *dq = >defer_queue; > + > + /* queue is full */ > + WARN_ON((dq->rear + 1) % (ATA_MAX_QUEUE + 1) == dq->front);

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Jeff Garzik
Peer Chen wrote: We did the many test with the new version driver and didn't encounter that problem, but in certain cases, DMASETUP command packets from drive to the controller are corrupted, and the controller issues an R_ERR to the drive. Drives that comply with SATA spec will re-transmit the

RE: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Peer Chen
We did the many test with the new version driver and didn't encounter that problem, but in certain cases, DMASETUP command packets from drive to the controller are corrupted, and the controller issues an R_ERR to the drive. Drives that comply with SATA spec will re-transmit the corrupted packet

RE: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Peer Chen
We did the many test with the new version driver and didn't encounter that problem, but in certain cases, DMASETUP command packets from drive to the controller are corrupted, and the controller issues an R_ERR to the drive. Drives that comply with SATA spec will re-transmit the corrupted packet

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Jeff Garzik
Peer Chen wrote: We did the many test with the new version driver and didn't encounter that problem, but in certain cases, DMASETUP command packets from drive to the controller are corrupted, and the controller issues an R_ERR to the drive. Drives that comply with SATA spec will re-transmit the

RE: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Kuan Luo
+static void nv_swncq_qc_to_dq(struct ata_port *ap, struct ata_queued_cmd *qc) +{ + struct nv_swncq_port_priv *pp = ap-private_data; + defer_queue_t *dq = pp-defer_queue; + + /* queue is full */ + WARN_ON((dq-rear + 1) % (ATA_MAX_QUEUE + 1) == dq-front); This is

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Andrew Morton
On Wed, 27 Jun 2007 17:09:29 +0800 Kuan Luo [EMAIL PROTECTED] wrote: +static void nv_swncq_qc_to_dq(struct ata_port *ap, struct ata_queued_cmd *qc) +{ + struct nv_swncq_port_priv *pp = ap-private_data; + defer_queue_t *dq = pp-defer_queue; + + /* queue is full */ +

RE: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Kuan Luo
A pretty good way. I will modify my code. -Original Message- From: Andrew Morton [mailto:[EMAIL PROTECTED] Sent: Wednesday, June 27, 2007 5:21 PM To: Kuan Luo Cc: linux-kernel@vger.kernel.org; [EMAIL PROTECTED]; Peer Chen Subject: Re: [PATCH] ata: Add the SW NCQ support to sata_nv for

RE: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Zoltan Boszormenyi
Hi, I am testing your current code with akpm's beautifying patches for about an hour now. I have seen no problems with it so far. **A pretty good way. I will modify my code. Please, cc me when sending your next patch to LKML, thanks. Best regards, Zoltán Böszörményi - To unsubscribe

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-27 Thread Prakash Punnoor
Am Mittwoch 27 Juni 2007 schrieb Peer Chen: We did the many test with the new version driver and didn't encounter that problem, but in certain cases, DMASETUP command packets from drive to the controller are corrupted, and the controller issues an R_ERR to the drive. Drives that comply with

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-26 Thread Andrew Morton
On Wed, 27 Jun 2007 11:04:44 +0800 "kuan luo" <[EMAIL PROTECTED]> wrote: > Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA > controller. > NCQ function is disable by default, you can enable it with 'swncq=1' > This patch adds a large amount of new trailing whitespace. >

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-26 Thread Robert Hancock
kuan luo wrote: Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1' Signed-off-by: Kuan Luo <[EMAIL PROTECTED]> Signed-off-by: Peer Chen <[EMAIL PROTECTED]> Haven't reviewed in detail, but does

[PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-26 Thread kuan luo
Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1' Signed-off-by: Kuan Luo <[EMAIL PROTECTED]> Signed-off-by: Peer Chen <[EMAIL PROTECTED]> --- diff -Nurp a/sata_nv.c b/sata_nv.c --- a/sata_nv.c

[PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-26 Thread kuan luo
Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1' Signed-off-by: Kuan Luo [EMAIL PROTECTED] Signed-off-by: Peer Chen [EMAIL PROTECTED] --- diff -Nurp a/sata_nv.c b/sata_nv.c --- a/sata_nv.c

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-26 Thread Robert Hancock
kuan luo wrote: Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1' Signed-off-by: Kuan Luo [EMAIL PROTECTED] Signed-off-by: Peer Chen [EMAIL PROTECTED] Haven't reviewed in detail, but does

Re: [PATCH] ata: Add the SW NCQ support to sata_nv for MCP51/MCP55/MCP61

2007-06-26 Thread Andrew Morton
On Wed, 27 Jun 2007 11:04:44 +0800 kuan luo [EMAIL PROTECTED] wrote: Add the Software NCQ support to sata_nv.c for MCP51/MCP55/MCP61 SATA controller. NCQ function is disable by default, you can enable it with 'swncq=1' This patch adds a large amount of new trailing whitespace. --- diff