Re: [PATCH] ata: pata_macio: add of_node_put()

2018-12-21 Thread Jens Axboe
On 12/20/18 6:09 PM, Frank Lee wrote: > On Fri, Dec 21, 2018 at 2:01 AM Jens Axboe wrote: >> >> On 12/20/18 10:03 AM, Bartlomiej Zolnierkiewicz wrote: >>> >>> On 11/21/2018 02:04 PM, Yangtao Li wrote: of_find_node_by_path() acquires a reference to the node returned by it and that

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-12-20 Thread Frank Lee
On Fri, Dec 21, 2018 at 2:01 AM Jens Axboe wrote: > > On 12/20/18 10:03 AM, Bartlomiej Zolnierkiewicz wrote: > > > > On 11/21/2018 02:04 PM, Yangtao Li wrote: > >> of_find_node_by_path() acquires a reference to the node > >> returned by it and that reference needs to be dropped by its caller. >

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-12-20 Thread Jens Axboe
On 12/20/18 10:03 AM, Bartlomiej Zolnierkiewicz wrote: > > On 11/21/2018 02:04 PM, Yangtao Li wrote: >> of_find_node_by_path() acquires a reference to the node >> returned by it and that reference needs to be dropped by its caller. >> bl_idle_init() doesn't do that, so fix it. >> >>

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-12-20 Thread Bartlomiej Zolnierkiewicz
On 11/21/2018 02:04 PM, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > bl_idle_init() doesn't do that, so fix it. > > Signed-off-by: Yangtao Li Acked-by: Bartlomiej Zolnierkiewicz >

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-11-22 Thread Sergei Shtylyov
On 21.11.2018 18:33, Frank Lee wrote: of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it. I thought we're inside pata_macio_cable_detect()? Hi Sergei： Yeah,this is a typo.

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-11-22 Thread Sergei Shtylyov
On 21.11.2018 18:33, Frank Lee wrote: of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it. I thought we're inside pata_macio_cable_detect()? Hi Sergei： Yeah,this is a typo.

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-11-21 Thread Frank Lee
On Wed, Nov 21, 2018 at 11:31 PM Frank Lee wrote: > > On Wed, Nov 21, 2018 at 11:24 PM Sergei Shtylyov > wrote: > > > > Hello! > > > > On 11/21/2018 04:04 PM, Yangtao Li wrote: > > > > > of_find_node_by_path() acquires a reference to the node > > > returned by it and that reference needs to be

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-11-21 Thread Frank Lee
On Wed, Nov 21, 2018 at 11:31 PM Frank Lee wrote: > > On Wed, Nov 21, 2018 at 11:24 PM Sergei Shtylyov > wrote: > > > > Hello! > > > > On 11/21/2018 04:04 PM, Yangtao Li wrote: > > > > > of_find_node_by_path() acquires a reference to the node > > > returned by it and that reference needs to be

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-11-21 Thread Frank Lee
On Wed, Nov 21, 2018 at 11:24 PM Sergei Shtylyov wrote: > > Hello! > > On 11/21/2018 04:04 PM, Yangtao Li wrote: > > > of_find_node_by_path() acquires a reference to the node > > returned by it and that reference needs to be dropped by its caller. > > bl_idle_init() doesn't do that, so fix it. >

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-11-21 Thread Frank Lee
On Wed, Nov 21, 2018 at 11:24 PM Sergei Shtylyov wrote: > > Hello! > > On 11/21/2018 04:04 PM, Yangtao Li wrote: > > > of_find_node_by_path() acquires a reference to the node > > returned by it and that reference needs to be dropped by its caller. > > bl_idle_init() doesn't do that, so fix it. >

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-11-21 Thread Sergei Shtylyov
Hello! On 11/21/2018 04:04 PM, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > bl_idle_init() doesn't do that, so fix it. I thought we're inside pata_macio_cable_detect()? > Signed-off-by:

Re: [PATCH] ata: pata_macio: add of_node_put()

2018-11-21 Thread Sergei Shtylyov
Hello! On 11/21/2018 04:04 PM, Yangtao Li wrote: > of_find_node_by_path() acquires a reference to the node > returned by it and that reference needs to be dropped by its caller. > bl_idle_init() doesn't do that, so fix it. I thought we're inside pata_macio_cable_detect()? > Signed-off-by:

[PATCH] ata: pata_macio: add of_node_put()

2018-11-21 Thread Yangtao Li
of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it. Signed-off-by: Yangtao Li --- drivers/ata/pata_macio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git

[PATCH] ata: pata_macio: add of_node_put()

2018-11-21 Thread Yangtao Li
of_find_node_by_path() acquires a reference to the node returned by it and that reference needs to be dropped by its caller. bl_idle_init() doesn't do that, so fix it. Signed-off-by: Yangtao Li --- drivers/ata/pata_macio.c | 2 ++ 1 file changed, 2 insertions(+) diff --git