Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

2021-01-14 Thread Sergei Shtylyov
On 1/12/21 2:15 PM, Sergei Shtylyov wrote: [...] >> From: Menglong Dong >> >> Coccinelle reports a redundant error print in rb532_pata_driver_probe. >> As 'platform_get_irq' already prints the error message, error print >> here is redundant and can be removed. >> >> Signed-off-by: Menglong Dong

Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

2021-01-14 Thread Menglong Dong
On Thu, Jan 14, 2021 at 4:30 PM Sergei Shtylyov wrote: [...] > > > > What does this 'MBR' mean? I am a novice~~~ > > Generally speaking, Master Boot Record. But I also use it to send you My > Best Regards. :-) Haha~, > > So, is it better to replace 'platform_get_irq' with > >

Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

2021-01-14 Thread Sergei Shtylyov
Hello! On 13.01.2021 17:04, Menglong Dong wrote: [...] irq = platform_get_irq(pdev, 0); - if (irq <= 0) { - dev_err(>dev, "no IRQ resource found\n"); + if (irq <= 0) return -ENOENT; This still beaks the probe deferral. :-( But that's another

Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

2021-01-13 Thread Menglong Dong
Hello, Sergei On Tue, Jan 12, 2021 at 7:15 PM Sergei Shtylyov wrote: > > Hello! > > On 1/12/21 5:36 AM, menglong8.d...@gmail.com wrote: > [] > > irq = platform_get_irq(pdev, 0); > > - if (irq <= 0) { > > - dev_err(>dev, "no IRQ resource found\n"); > > + if (irq <=

Re: [PATCH] ata: remove redundant error print in rb532_pata_driver_probe

2021-01-12 Thread Sergei Shtylyov
Hello! On 1/12/21 5:36 AM, menglong8.d...@gmail.com wrote: > From: Menglong Dong > > Coccinelle reports a redundant error print in rb532_pata_driver_probe. > As 'platform_get_irq' already prints the error message, error print > here is redundant and can be removed. > > Signed-off-by: Menglong

[PATCH] ata: remove redundant error print in rb532_pata_driver_probe

2021-01-11 Thread menglong8 . dong
From: Menglong Dong Coccinelle reports a redundant error print in rb532_pata_driver_probe. As 'platform_get_irq' already prints the error message, error print here is redundant and can be removed. Signed-off-by: Menglong Dong --- drivers/ata/pata_rb532_cf.c | 4 +--- 1 file changed, 1