Re: [PATCH] ath9k_htc: Fix skb leaks

2013-01-09 Thread Sujith Manoharan
Larry Finger wrote: > > I'll come up with a patch and see if kmemleak still complains. > > Did I miss your posting on this issue? Nope, I haven't got to this yet, sorry. I'll try to send a patch by today. Sujith -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the bo

Re: [PATCH] ath9k_htc: Fix skb leaks

2013-01-08 Thread Larry Finger
On 01/01/2013 11:26 PM, Sujith Manoharan wrote: Larry Finger wrote: My only counter argument is that none of the other paths that get to ath9k_htc_txcompletion_cb() leak the skb. It only happens for the path that goes through htc_connect_service(). Sure, but the TX completion handler would be

Re: [PATCH] ath9k_htc: Fix skb leaks

2013-01-01 Thread Sujith Manoharan
Larry Finger wrote: > My only counter argument is that none of the other paths that get to > ath9k_htc_txcompletion_cb() leak the skb. It only happens for the path that > goes > through htc_connect_service(). Sure, but the TX completion handler would be invoked for every skb that is passed to

Re: [PATCH] ath9k_htc: Fix skb leaks

2013-01-01 Thread Larry Finger
On 01/01/2013 10:30 PM, Sujith Manoharan wrote: Larry Finger wrote: diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c b/drivers/net/wireless/ath/ath9k/htc_hst.c index 4a9570d..a304748 100644 --- a/drivers/net/wireless/ath/ath9k/htc_hst.c +++ b/drivers/net/wireless/ath/ath9k/htc_hst.c @@ -27

Re: [PATCH] ath9k_htc: Fix skb leaks

2013-01-01 Thread Sujith Manoharan
Larry Finger wrote: > diff --git a/drivers/net/wireless/ath/ath9k/htc_hst.c > b/drivers/net/wireless/ath/ath9k/htc_hst.c > index 4a9570d..a304748 100644 > --- a/drivers/net/wireless/ath/ath9k/htc_hst.c > +++ b/drivers/net/wireless/ath/ath9k/htc_hst.c > @@ -278,10 +278,12 @@ int htc_connect_service

[PATCH] ath9k_htc: Fix skb leaks

2013-01-01 Thread Larry Finger
Running with kmemleak shows that this driver leaks every skb allocated in routine htc_connect_service() whether the service connection succeeds or fails. Signed-off-by: Larry Finger Cc: Stable Cc: "Luis R. Rodriguez" Cc: Vasanthakumar Thiagarajan Cc: Senthil Balasubramanian Cc: linux-wirel...