Re: [PATCH] atm: ambassador: remove h from printk format specifier

2020-12-18 Thread Jakub Kicinski
On Thu, 17 Dec 2020 14:03:07 -0800 Tom Rix wrote: > On 12/17/20 9:28 AM, Jakub Kicinski wrote: > > On Thu, 17 Dec 2020 05:17:24 -0800 Tom Rix wrote: > >> On 12/16/20 4:45 PM, Jakub Kicinski wrote: > >>> On Tue, 15 Dec 2020 06:22:28 -0800 t...@redhat.com wrote: > From: Tom Rix >

Re: [PATCH] atm: ambassador: remove h from printk format specifier

2020-12-17 Thread Tom Rix
On 12/17/20 9:28 AM, Jakub Kicinski wrote: > On Thu, 17 Dec 2020 05:17:24 -0800 Tom Rix wrote: >> On 12/16/20 4:45 PM, Jakub Kicinski wrote: >>> On Tue, 15 Dec 2020 06:22:28 -0800 t...@redhat.com wrote: From: Tom Rix See Documentation/core-api/printk-formats.rst. h should

Re: [PATCH] atm: ambassador: remove h from printk format specifier

2020-12-17 Thread Jakub Kicinski
On Thu, 17 Dec 2020 05:17:24 -0800 Tom Rix wrote: > On 12/16/20 4:45 PM, Jakub Kicinski wrote: > > On Tue, 15 Dec 2020 06:22:28 -0800 t...@redhat.com wrote: > >> From: Tom Rix > >> > >> See Documentation/core-api/printk-formats.rst. > >> h should no longer be used in the format specifier for

Re: [PATCH] atm: ambassador: remove h from printk format specifier

2020-12-17 Thread Tom Rix
On 12/16/20 4:45 PM, Jakub Kicinski wrote: > On Tue, 15 Dec 2020 06:22:28 -0800 t...@redhat.com wrote: >> From: Tom Rix >> >> See Documentation/core-api/printk-formats.rst. >> h should no longer be used in the format specifier for printk. >> >> Signed-off-by: Tom Rix > That's for new code I

Re: [PATCH] atm: ambassador: remove h from printk format specifier

2020-12-16 Thread Jakub Kicinski
On Tue, 15 Dec 2020 06:22:28 -0800 t...@redhat.com wrote: > From: Tom Rix > > See Documentation/core-api/printk-formats.rst. > h should no longer be used in the format specifier for printk. > > Signed-off-by: Tom Rix That's for new code I assume? What's the harm in leaving this ancient code

[PATCH] atm: ambassador: remove h from printk format specifier

2020-12-15 Thread trix
From: Tom Rix See Documentation/core-api/printk-formats.rst. h should no longer be used in the format specifier for printk. Signed-off-by: Tom Rix --- drivers/atm/ambassador.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/atm/ambassador.c