Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 14:18:18 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Haavard, > > > Hrm. We probably need to lock while updating icount. That's a problem > > since we do that from the tx interrupt handler...and I don't suppose we > > want to move most of the atmel_tx_chars() code i

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Remy Bohmer
Hello Haavard, > Hrm. We probably need to lock while updating icount. That's a problem > since we do that from the tx interrupt handler...and I don't suppose we > want to move most of the atmel_tx_chars() code into the tasklet too...? I do not see a reason why not moving transmit to a tasklet. It

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Wed, 19 Dec 2007 13:50:16 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Haavard, > > > Hmm...perhaps we can eliminate the locking in the status handler > > too...? Does anyone see a problem with this patch? > > I have not seen any problem so far, besides, I am very happy with a > l

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Remy Bohmer
Hello Haavard, > Hmm...perhaps we can eliminate the locking in the status handler > too...? Does anyone see a problem with this patch? I have not seen any problem so far, besides, I am very happy with a lockless interrupt handling, because this helps reducing latencies. Tested it on top of the o

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-19 Thread Haavard Skinnemoen
On Tue, 18 Dec 2007 16:23:11 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Preempt-RT now absolutely requires my (4th) IRQ_NODELAY patch, because > the spinlock now is always inside the code, and not only in > theexception path, and thus without my NO_DELAY patch we have a panic > during boot.

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-18 Thread Remy Bohmer
Hello Haavard, > > BTW: Attached I have added a 2nd patch that I use for Preempt-RT. (For > > cleaner startup, and to get rid of useless IRQ-threads. > > Hrm. That assumption isn't valid on AVR32...on AP7000, for example, > IRQ1 is used by the LCD controller. In that case, forget that (dirty) pat

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
Crud...my mailer helpfully filtered this into the huge linux-kernel bin instead of leaving it in my inbox... On Tue, 18 Dec 2007 16:23:11 +0100 "Remy Bohmer" <[EMAIL PROTECTED]> wrote: > Hello Haavard, > > A few remarks: > > > From: Remy Bohmer <[EMAIL PROTECTED]> > > My name, at your address

Re: [PATCH] atmel_serial: Split the interrupt handler

2007-12-18 Thread Remy Bohmer
Hello Haavard, A few remarks: > From: Remy Bohmer <[EMAIL PROTECTED]> My name, at your address ;-))) > This patch splits up the interrupt handler of the serial port > into a interrupt top-half and a tasklet. I see you moved the handling of the sysrq-key to the tasklet. This was actually a very

[PATCH] atmel_serial: Split the interrupt handler

2007-12-18 Thread Haavard Skinnemoen
From: Remy Bohmer <[EMAIL PROTECTED]> This patch splits up the interrupt handler of the serial port into a interrupt top-half and a tasklet. The goal is to get the interrupt top-half as short as possible to minimize latencies on interrupts. But the old code also does some calls in the interrupt h