Re: [PATCH] audit: Replace zero-length array with flexible-array

2020-05-08 Thread Gustavo A. R. Silva
On Thu, May 07, 2020 at 10:52:09PM -0400, Paul Moore wrote: > > > > Signed-off-by: Gustavo A. R. Silva > > --- > > include/linux/audit.h |2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > Merged into audit/next, thanks! > Thanks, Paul. -- Gustavo

Re: [PATCH] audit: Replace zero-length array with flexible-array

2020-05-08 Thread Richard Guy Briggs
On 2020-05-07 17:49, Gustavo A. R. Silva wrote: > On Thu, May 07, 2020 at 05:58:13PM -0400, Richard Guy Briggs wrote: > > On 2020-05-07 13:50, Gustavo A. R. Silva wrote: > > > The current codebase makes use of the zero-length array language > > > extension to the C90 standard, but the preferred

Re: [PATCH] audit: Replace zero-length array with flexible-array

2020-05-07 Thread Paul Moore
On Thu, May 7, 2020 at 2:46 PM Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: >

Re: [PATCH] audit: Replace zero-length array with flexible-array

2020-05-07 Thread Paul Moore
On Thu, May 7, 2020 at 6:45 PM Gustavo A. R. Silva wrote: > I wouldn't advise to make any of these conversions in include/uapi/ ... Yes, let's not make changes like this to anything under include/uapi; the potential reward doesn't outweigh the risks. -- paul moore www.paul-moore.com

Re: [PATCH] audit: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
On Thu, May 07, 2020 at 05:58:13PM -0400, Richard Guy Briggs wrote: > On 2020-05-07 13:50, Gustavo A. R. Silva wrote: > > The current codebase makes use of the zero-length array language > > extension to the C90 standard, but the preferred mechanism to declare > > variable-length types such as

Re: [PATCH] audit: Replace zero-length array with flexible-array

2020-05-07 Thread Richard Guy Briggs
On 2020-05-07 13:50, Gustavo A. R. Silva wrote: > The current codebase makes use of the zero-length array language > extension to the C90 standard, but the preferred mechanism to declare > variable-length types such as these ones is a flexible array member[1][2], > introduced in C99: > > struct

[PATCH] audit: Replace zero-length array with flexible-array

2020-05-07 Thread Gustavo A. R. Silva
The current codebase makes use of the zero-length array language extension to the C90 standard, but the preferred mechanism to declare variable-length types such as these ones is a flexible array member[1][2], introduced in C99: struct foo { int stuff; struct boo array[]; }; By