Re: [PATCH] audit_tree: keep inode pinned

2014-11-12 Thread Richard Guy Briggs
On 14/11/05, Miklos Szeredi wrote: > On Wed, Nov 5, 2014 at 5:58 PM, Richard Guy Briggs wrote: > > On 14/11/04, Miklos Szeredi wrote: > >> From: Miklos Szeredi > > > > Hi Miklos, > > > >> Audit rules disappear when an inode they watch is evicted from the cache. > >> This is likely not what we wan

Re: [PATCH] audit_tree: keep inode pinned

2014-11-11 Thread Paul Moore
On Tue, Nov 4, 2014 at 5:27 AM, Miklos Szeredi wrote: > From: Miklos Szeredi > > Audit rules disappear when an inode they watch is evicted from the cache. > This is likely not what we want. > > The guilty commit is "fsnotify: allow marks to not pin inodes in core", > which didn't take into accoun

Re: [PATCH] audit_tree: keep inode pinned

2014-11-05 Thread Miklos Szeredi
On Wed, Nov 5, 2014 at 5:58 PM, Richard Guy Briggs wrote: > On 14/11/04, Miklos Szeredi wrote: >> From: Miklos Szeredi > > Hi Miklos, > >> Audit rules disappear when an inode they watch is evicted from the cache. >> This is likely not what we want. >> >> The guilty commit is "fsnotify: allow mark

Re: [PATCH] audit_tree: keep inode pinned

2014-11-05 Thread Richard Guy Briggs
On 14/11/04, Miklos Szeredi wrote: > From: Miklos Szeredi Hi Miklos, > Audit rules disappear when an inode they watch is evicted from the cache. > This is likely not what we want. > > The guilty commit is "fsnotify: allow marks to not pin inodes in core", > which didn't take into account that a

Re: [PATCH] audit_tree: keep inode pinned

2014-11-04 Thread Eric Paris
[adding paul and richard] On Tue, 2014-11-04 at 11:27 +0100, Miklos Szeredi wrote: > From: Miklos Szeredi > > Audit rules disappear when an inode they watch is evicted from the cache. > This is likely not what we want. > > The guilty commit is "fsnotify: allow marks to not pin inodes in core",

[PATCH] audit_tree: keep inode pinned

2014-11-04 Thread Miklos Szeredi
From: Miklos Szeredi Audit rules disappear when an inode they watch is evicted from the cache. This is likely not what we want. The guilty commit is "fsnotify: allow marks to not pin inodes in core", which didn't take into account that audit_tree adds watches with a zero mask. Adding any mask s