Re: [PATCH] auxdisplay: ht16k33: Make ht16k33_fb_fix and ht16k33_fb_var constant

2019-08-20 Thread Robin van der Gracht
On 2019-08-19 09:51, Nishka Dasgupta wrote: The static structures ht16k33_fb_fix and ht16k33_fb_var, of types fb_fix_screeninfo and fb_var_screeninfo respectively, are not used except to be copied into other variables. Hence make both of them constant to prevent unintended modification. Issue

Re: [PATCH] auxdisplay: ht16k33: Make ht16k33_fb_fix and ht16k33_fb_var constant

2019-08-19 Thread Miguel Ojeda
On Mon, Aug 19, 2019 at 9:51 AM Nishka Dasgupta wrote: > > The static structures ht16k33_fb_fix and ht16k33_fb_var, of types > fb_fix_screeninfo and fb_var_screeninfo respectively, are not used > except to be copied into other variables. Hence make both of them > constant to prevent unintended

[PATCH] auxdisplay: ht16k33: Make ht16k33_fb_fix and ht16k33_fb_var constant

2019-08-19 Thread Nishka Dasgupta
The static structures ht16k33_fb_fix and ht16k33_fb_var, of types fb_fix_screeninfo and fb_var_screeninfo respectively, are not used except to be copied into other variables. Hence make both of them constant to prevent unintended modification. Issue found with Coccinelle. Signed-off-by: Nishka